Skip to content

Conversation

auduchinok
Copy link
Member

Continuation of #18645. Fixes DeclaringEntity for members defined in an abbreviated type extension:

module Module

type d = System.Collections.Generic.IDictionary<int, int>

type d{caret} with
    member x.P = 1

Since these members are now being analyzed due to the added recovery, it gets to a state that was never explicitly supported and tested, and there are places that are not ready for it.

The problem I've encountered in the Rider plugin tests is P member above assumes it's defined in the actual IDicitionary type, not in Module.

Copy link
Contributor

❗ Release notes required

@auduchinok,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md No release notes found or release notes format is not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

1 participant