Check the length of an NDEF message before checking the end terminato…

…r as it is optional and could result in an IndexOfOfRangeException
dotnet · Mar 4, 2024 · 7d1511b · 7d1511b
1 parent 202ff2d
commit 7d1511b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/devices/Card/Ndef/NdefMessage.cs b/src/devices/Card/Ndef/NdefMessage.cs
@@ -70,8 +70,8 @@ public static (int Start, int Size) GetStartSizeNdef(Span<byte> toExtract)
         public static byte[]? ExtractMessage(Span<byte> toExtract)
         {
             var (idx, size) = GetStartSizeNdef(toExtract);
-            // Finally check that the end terminator TLV is 0xFE
-            bool isRealEnd = toExtract[idx + size] == 0xFE;
+            // Finally check that the optional end terminator TLV is 0xFE
+            bool isRealEnd = (toExtract.Length == idx + size) || (toExtract[idx + size] == 0xFE);
             if (!isRealEnd)
             {
                 return new byte[0];