Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler multi threading support #2240

Merged
merged 437 commits into from
Jan 8, 2024
Merged

Compiler multi threading support #2240

merged 437 commits into from
Jan 8, 2024

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Dec 16, 2023 •
edited by ghost
Loading

Various updates to the Arduino Compiler:

  • Supports latest .NET 6.0 SDK/Runtime
  • Supports multi-threading (tasks, threads, including async calls)
  • Added many low-level functions, in particular for file I/O
  • Improved memory management

Known issues:

  • The new version appears to be quite a bit slower than the old one, reason is unclear
  • Use of PSRam isn't working properly yet
Microsoft Reviewers: Open in CodeFlow

pgrawehr and others added 30 commits May 2, 2021 14:55
@pgrawehr
Extend examples, fix Dictionary bugs
c459983
@pgrawehr
Make sure EqualityComparer..cctors are sorted first
43ad122
@pgrawehr
Remove function - no intrinsic required
5833e50 
The original implementation works just fine
@pgrawehr
Another comparison to improve startup sequence anticipation
332fc0c
@pgrawehr
Code cleanup
138f337
@pgrawehr
These tests are to big to be run from RAM
f94da1e
@pgrawehr
Extended example works
c4b05af
@pgrawehr
Support communication via WiFi
a27dce1
@pgrawehr
Disable unused gas sensor
bb1e538 
Causes wrong temperature readings
@pgrawehr
Add humidity sensor measurement
046c3e0
@pgrawehr
Extend the example
3838f8d
@pgrawehr
Add implementation of Number.ToString() to library, for debugging pur…
e3b3812 
…poses

This code from the System library implements the number formatting.
Following the code makes it a lot easier to debug EE errors (such as
missing sign extensions)
@pgrawehr
Sort unsigned, so that binary search works
606c5cb
@pgrawehr
Add dew point
059aae5
@pgrawehr
Start adding File I/O support
47ba4e8
@pgrawehr
Broken Weather stuff
a9b8a75
@pgrawehr
Intermediate commit
bc24078
@pgrawehr
Next intermediate commit
6a6ee60
@pgrawehr
File system support additions
46ee69a
@pgrawehr
Further work on file system support
225d2e4
@pgrawehr
Partial file system support
132d555
@pgrawehr
Moves to FirmataCommandSequence
ff17f55
@pgrawehr
Revert "Moves to FirmataCommandSequence"
cd55b87 
This reverts commit ff17f55.
@pgrawehr
File system support for ESP32 almost working
73174cf 
But seems to require proper try/catch/finally support,
otherwise files are not closed.
@pgrawehr
Basic support for exception handling added
a783199
@pgrawehr
Use common constants
38ae7ba
@pgrawehr
Write as ASCII
fa305f8
@pgrawehr
Remove wrong warnings
ffa18e8
@pgrawehr
Convert List to Dictionary
79a0bcb 
By first only checking the name, method comparison is
significantly faster (up to 10 times)
@pgrawehr
Support for frequency measurement using Arduino
734b79a
@pgrawehr
Use short message if possible
365bf6f
@pgrawehr
Will need a new table for a performance improvement
ee0db69
@pgrawehr
Fix behavior of EnumEquals implementation
53e4a10
@pgrawehr
Fix Class sorting
aecf3b0 
Was crashing because some array types are
unexpectedly assignable to each other.
@pgrawehr
More uncritical changes
408ca26
@pgrawehr
Next step, still acceptable memory use
e81d987
@pgrawehr
Where's the difference?
b46ccc0
@pgrawehr
Still good, now only the UnitsNet update itself can be the culpit?!?
97fb605
@pgrawehr
Update UnitsNet to V5.0
c8904b6 
Seems to work now
@pgrawehr
Merge remote-tracking branch 'remotes/dotnet/main' into UnitsNet5_Sec…
0fc9143 
…ondTry
@pgrawehr
Merge remote-tracking branch 'remotes/dotnet/main' into Compiler_Mult…
00790d5 
…iThreading
@pgrawehr
Fix build
2d5b918
@pgrawehr
These new methods are required
17850de
@pgrawehr
When not starting the debugger, still correctly call the main method
e30b31e
@pgrawehr
New compiler command group: Exec
28755dd 
Currently only one new command: --stop
@pgrawehr
Logging works in simulation
e1ba43a
@pgrawehr
Extended WeatherStation almost works
b40bd59
@pgrawehr
Try to add separate workflow
8d86963
@pgrawehr
Merge remote-tracking branch 'remotes/dotnet/main' into Compiler_Mult…
c7e1756 
…iThreading

# Conflicts:
#	src/devices/Arduino/FirmataDevice.cs
#	tools/ArduinoCsCompiler/tests/FirmataIlExecutorTests.cs
@pgrawehr
Fix merge issues
d3976a0
@pgrawehr
Build the compiler in a separate pipeline
cfa8a54
@pgrawehr
Markdown errors fixed
cfbb403
@pgrawehr
Remove now unused job
d9cb6e9
@pgrawehr pgrawehr marked this pull request as ready for review December 17, 2023 14:46
Ellerbach
Ellerbach approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work placed here and not easy to review! All up, it seems good to me.

@pgrawehr pgrawehr merged commit a5d57ad into dotnet:main Jan 8, 2024
10 checks passed
@pgrawehr pgrawehr mentioned this pull request Jan 11, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgrawehr @Ellerbach