Give better wiring instructions for 1-wire devices. #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided diagram is wrong (10k resistor is in series with the data line, leading to unreliable operation). I believe it was intended as a pullup (as recommended by the datasheet) However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v. To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).
ghost
added
the
area-device-bindings
pgrawehr
reviewed
Dec 28, 2023
|
Note: I took the liberty to move forward this documentation PR by adjusting the graphic and the source file. |
|
@Hello1024 you will have to accept the agrement, so that we can merge your PR with my adjustments once the pipelines will be green. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The drawing is still wrong. The resistor should be a pullup, but currently it is in-line with the data line. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
[Triage] @Hello1024: This would be ready to merge, but you need to agree to the license terms. Check the post from the dotnet-policy-service bot above. |
|
[Triage] @Hello1024 please accept the licence agreement so we can merge! Thanks a lot! |
|
@dotnet-policy-service agree |
pgrawehr
approved these changes
Jul 24, 2024
|
@Hello1024 Thanks. Merged now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided diagram is wrong (10k resistor is in series with the data line, leading to the device not working). I believe it was intended as a pullup (as recommended by the datasheet)
However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v.
To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).
This removes the incorrect wiring diagram.
Microsoft Reviewers: Open in CodeFlow