Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better wiring instructions for 1-wire devices. #2258

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

Hello1024
Copy link
Contributor

@Hello1024 Hello1024 commented Dec 28, 2023

The provided diagram is wrong (10k resistor is in series with the data line, leading to the device not working). I believe it was intended as a pullup (as recommended by the datasheet)

However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v.

To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).

This removes the incorrect wiring diagram.

Microsoft Reviewers: Open in CodeFlow

The provided diagram is wrong (10k resistor is in series with the data line, leading to unreliable operation).  I believe it was intended as a pullup (as recommended by the datasheet)

However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v.

To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).
@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Dec 28, 2023
Copy link
Contributor

@pgrawehr pgrawehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but please delete the wrong schema image then.

@Ellerbach
Copy link
Member

Note: I took the liberty to move forward this documentation PR by adjusting the graphic and the source file.

@Ellerbach
Copy link
Member

@Hello1024 you will have to accept the agrement, so that we can merge your PR with my adjustments once the pipelines will be green.

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr
Copy link
Contributor

pgrawehr commented Apr 9, 2024

The drawing is still wrong. The resistor should be a pullup, but currently it is in-line with the data line.

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr
Copy link
Contributor

[Triage] @Hello1024: This would be ready to merge, but you need to agree to the license terms. Check the post from the dotnet-policy-service bot above.

@Ellerbach
Copy link
Member

[Triage] @Hello1024 please accept the licence agreement so we can merge! Thanks a lot!

@joperezr joperezr assigned Ellerbach and joperezr and unassigned Ellerbach Jun 20, 2024
@Hello1024
Copy link
Contributor Author

@dotnet-policy-service agree

@pgrawehr pgrawehr merged commit c387475 into dotnet:main Jul 24, 2024
10 checks passed
@pgrawehr
Copy link
Contributor

@Hello1024 Thanks. Merged now.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants