Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a compiler NotImplementedException #2331

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Fix a compiler NotImplementedException #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93c1461
Fix a compiler warning
pgrawehr Jul 11, 2024
89f2746
Prevent NotImplementedException in some test cases
pgrawehr Jul 11, 2024
ff1d570
No need for two builds on a push to a PR
pgrawehr Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/arduino.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ name: Arduino_Compiler_CI

# Controls when the workflow will run
on:
# Triggers the workflow on push or pull request events
push:

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
pull_request:
Expand Down
2 changes: 2 additions & 0 deletions src/System.Device.Gpio/System/Device/Gpio/Drivers/Libgpiod/LibGpiodDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@ protected internal override void Write(int pinNumber, PinValue value)
public override ComponentInformation QueryComponentInformation()
{
var ret = new ComponentInformation(this, "Libgpiod Wrapper driver");
#pragma warning disable SDGPIO0001
ret.Properties.Add("Version", Version.ToString());
ret.AddSubComponent(GetDriver().QueryComponentInformation());
#pragma warning restore SDGPIO0001
return ret;
}

Expand Down
2 changes: 1 addition & 1 deletion tools/ArduinoCsCompiler/Runtime/MiniInterop.Kernel32.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ internal static unsafe int CompareStringOrdinal(
internal static unsafe int LCMapStringEx(string lpLocaleName, uint dwMapFlags, char* lpSrcStr, int cchsrc, void* lpDestStr,
int cchDest, void* lpVersionInformation, void* lpReserved, IntPtr sortHandle)
{
throw new NotImplementedException();
return 0; // Can apparently be null in InvariantCulture mode.
}

internal static int FindNLSString(
Expand Down
Loading