Various improvements to Nmea and AIS parsers #2430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
area-device-bindings
krwq
reviewed
Oct 16, 2025
krwq
reviewed
Oct 16, 2025
krwq
reviewed
Oct 16, 2025
krwq
reviewed
Oct 16, 2025
krwq
reviewed
Oct 16, 2025
| public Angle? MagneticVariation | ||
| { | ||
| get; | ||
| private set; |
There was a problem hiding this comment.
why no setter? (others do have it?)
There was a problem hiding this comment.
Because that's an output from this class, not an input like most other properties.
krwq
reviewed
Oct 16, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
krwq
reviewed
Oct 23, 2025
| SendCommand(seq); | ||
| } | ||
|
|
||
| public TimeSpan QueryAnalogInputSamplingInterval() |
There was a problem hiding this comment.
consider
Suggested change
| public TimeSpan QueryAnalogInputSamplingInterval() | |
| public TimeSpan AnalogInputSamplingInterval => ... |
or renaming Query to Get to make it sound simpler
krwq
reviewed
Oct 23, 2025
| /// This is useful to e.g. trigger an error only after an input value | ||
| /// is high for at least a certain time. | ||
| /// </summary> | ||
| public class HysteresisFilter |
There was a problem hiding this comment.
I'm not sure about the word Filter in the name but I cannot think of anything better... maybe HysteresisFunction?
krwq
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NMEA and AIS features verified in real-world scenarios.