Enable APICompat for non-stable projects #7340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to mirror these to dotnet-public. Doing so, then will rerun. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
GetSortIndices was accidentally regressed in the last release.��This compat suppression is permitting the fix for that regression.
ericstj
commented
Dec 17, 2024
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Microsoft.ML.GenAI.Core.CausalLMModelInput.#ctor(TorchSharp.torch.Tensor,TorchSharp.torch.Tensor,TorchSharp.torch.Tensor,System.Int32,TorchSharp.torch.Tensor,System.Boolean,System.Boolean,System.Boolean)</Target> |
There was a problem hiding this comment.
@LittleLittleCloud @stephentoub are these intentional breaking changes over last release?
Let me know if you'd prefer we not do API compat for this lib if you intend to make lots of breaking changes like this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7340 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 1473 1473
Lines 270771 270771
Branches 27884 27884
=======================================
+ Hits 186518 186534 +16
+ Misses 76979 76966 -13
+ Partials 7274 7271 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ericstj
commented
Dec 17, 2024
| <!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> |
There was a problem hiding this comment.
@LittleLittleCloud more GenAI suppressions to look at.
This was referenced Dec 18, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help folks avoid problems like #7331