[RGen] Use the correct attribute for field properties. #21959

mandel-macaque · 2025-01-13T19:19:52Z

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export to Field which allows to mark a property as a field AND will allow use to add the library name.

This change + the one in PR
#21945 improves the way the Library.g.cs file is generated.

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export<Field> to Field<Property> which allows to mark a property as a field AND will allow use to add the library name. This change + the one in PR #21945 improves the way the Library.g.cs file is generated.

github-actions · 2025-01-13T19:24:13Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

stephen-hawley

Couple of minor things, but nothing to hold you up.

stephen-hawley · 2025-01-13T19:50:02Z

src/rgen/Microsoft.Macios.Generator/Attributes/FieldData.cs

-				error = new (ParsingError.UnknownConstructor, attributeData.ConstructorArguments.Length);
+
+			if (attributeData.ConstructorArguments [1].Value is string) {
+				libraryName = (string?) attributeData.ConstructorArguments [1].Value!;


why not:

if (attributeData.ConstructorArguments [1].Value is string libValue) { libraryName = (string?)libValue; }

I did not think about it, I'll update the code.

now that I'm chasing it, I just found it weird to assign the variable, I wish the 'is' had a way to set the variable to be one you already have.

vs-mobiletools-engineering-service2 · 2025-01-14T13:00:40Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:14:08Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:33:34Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:35:06Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:35:23Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:40:16Z

❗ API diff for current PR / commit (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T13:41:33Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 9de395d62bfc360a3370767acfefa26bf2b1dd19 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T15:46:52Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: af3a463905b3e27405990cf3e9b682c8ec05bc8f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T16:23:38Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: af3a463905b3e27405990cf3e9b682c8ec05bc8f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-14T19:18:15Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ linker tests

1 tests failed, 39 tests passed.

trimmode link/Mac Catalyst/Release: Failed (Test run failed.
Tests run: 130 Passed: 125 Inconclusive: 0 Failed: 1 Ignored: 4)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: af3a463905b3e27405990cf3e9b682c8ec05bc8f [PR build]

mandel-macaque and others added 2 commits January 13, 2025 14:13

Auto-format source code

af3a463

dalexsoto approved these changes Jan 13, 2025

View reviewed changes

stephen-hawley approved these changes Jan 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Jan 14, 2025

View reviewed changes

mandel-macaque merged commit 9de395d into main Jan 14, 2025
15 of 17 checks passed

mandel-macaque deleted the dev/mandel/fields-classes-field-attr branch January 14, 2025 09:47

This comment has been minimized.

Sign in to view

[RGen] Use the correct attribute for field properties. #21959

[RGen] Use the correct attribute for field properties. #21959

Conversation

mandel-macaque commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

⚠️ Your code has been reformatted. ⚠️

stephen-hawley left a comment

Choose a reason for hiding this comment

stephen-hawley Jan 13, 2025

Choose a reason for hiding this comment

mandel-macaque Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

mandel-macaque Jan 13, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 14, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Jan 14, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 14, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 14, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 14, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 14, 2025

❗ API diff for current PR / commit (Breaking changes)

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 14, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 14, 2025

✅ [PR Build] Build passed (Build packages) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 14, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 14, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ linker tests

Successes

mandel-macaque Jan 13, 2025 •

edited

Loading