[RGen] Provide a method that returns the selector for an accessor. #21995

mandel-macaque · 2025-01-16T18:51:55Z

The method takes into account the property associated with the accessor and any possible export method that has been added to the accessor itself.

The setter label for the default case uses the Registrar.core code.

The method takes into account the property associated with the accessor and any possible export method that has been added to the accessor itself. The setter label for the default case uses the Registrar.core code.

Copilot

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

src/rgen/Microsoft.Macios.Generator/Microsoft.Macios.Generator.csproj: Language not supported

Copilot · 2025-01-16T18:52:22Z

src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs

+		// is the case, we will use the selector in that attribute. Otherwise, we have:
+		//
+		// * getter: return the property selector.
+		// * setter: use the registrar code (it has the right logic) ato get the setter.


The word 'ato' is a typo. It should be 'to'.

src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs

github-actions · 2025-01-16T18:58:35Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto · 2025-01-17T05:07:28Z

/azp run

azure-pipelines · 2025-01-17T05:07:46Z

Azure Pipelines failed to run 2 pipeline(s).

vs-mobiletools-engineering-service2 · 2025-01-18T00:19:01Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T00:26:52Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T00:42:47Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T01:01:23Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T01:02:55Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T01:03:29Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T01:03:48Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T01:06:12Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T02:53:46Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-18T05:24:05Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fb7073e0b3b7bd4f07d495c878940ef97b71a3c7 [PR build]

[RGen] Provide a method that returns the selector for an accessor.

2734a36

The method takes into account the property associated with the accessor and any possible export method that has been added to the accessor itself. The setter label for the default case uses the Registrar.core code.

mandel-macaque requested a review from Copilot January 16, 2025 18:51

Copilot AI reviewed Jan 16, 2025

View reviewed changes

mandel-macaque commented Jan 16, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 2 commits January 16, 2025 13:54

typo.

a33cfe3

Auto-format source code

64bbd26

dalexsoto approved these changes Jan 16, 2025

View reviewed changes

rolfbjarne approved these changes Jan 16, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/get-selector-for-accessor

b288190

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/get-selector-for-accessor

e67d2fd

This comment has been minimized.

Sign in to view

mandel-macaque merged commit fb7073e into main Jan 17, 2025
48 checks passed

mandel-macaque deleted the dev/mandel/get-selector-for-accessor branch January 17, 2025 23:37

[RGen] Provide a method that returns the selector for an accessor. #21995

[RGen] Provide a method that returns the selector for an accessor. #21995

Conversation

mandel-macaque commented Jan 16, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto commented Jan 17, 2025

azure-pipelines bot commented Jan 17, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 18, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 18, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Jan 18, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 18, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 18, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 18, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 18, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 18, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 18, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

vs-mobiletools-engineering-service2 commented Jan 18, 2025

💻 [CI Build] Windows Integration Tests passed 💻