-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcode16.3] Merge main into xcode16.3. #22276
[xcode16.3] Merge main into xcode16.3. #22276
Conversation
Looks like we landed code that should have never landed. But there is no issues because the API is marked as experimental. It is the rgen binding API.
In order to simplify the BindAs/BindFrom code, new methods were added to the smart enums generated by bgen. We have to do the same in rgen. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
Add the missing notification configuration options for the FieldAttribute. Do remember that we will use the analyzer to make sure that those options are only used when the user passes the notification flag. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
* Add missing availability attributes for .NET. * Remove !.NET availability attributes / code. * Remove redundant .NET availability attributes. * Don't use deprecated APIs when there's an equivalent non-deprecated version available. This is a step towards fixing #21185.
As with previous changes, move to use a method group instead of a lambda with a using block. We only add the new methods in those platforms that have the specifict frameworks by using partial class. That way we keep the code cleaner than with a collection of #if statements. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
…22265) Implement the notifications helper class for those properties marked as notifications. Code supports the same configuration options as bgen and the test ensures that all configurations are tested: 1. No special config 2. Special args. 3. Special notification center. 4. Special args and notification center. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
We talked about it in a PR in which we agreed to have the same name and have it as an overload.
Because installing simulators means running a C# project, which requires .NET to build. Also improve the .NET version check systemdependencies.sh to not blindly try to execute `dotnet`, but check for its presence first. This fixes a couple of issues on bots that don't have .NET installed.
✅ [PR Build #c13ebbb] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #c13ebbb] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #c13ebbb] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [PR Build #c13ebbb] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build #c13ebbb] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build #c13ebbb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [PR Build #c13ebbb] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
❗ API diff for current PR / commit (Breaking changes).NET ( ❗ Breaking changes ❗ )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #c13ebbb] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 7 tests failed, 102 tests passed. Failures❌ dotnettests tests (iOS) [attempt 2]
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst) [attempt 2]
Html Report (VSDrops) Download ❌ dotnettests tests (macOS) [attempt 2]
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS) [attempt 2]
Html Report (VSDrops) Download ❌ introspection tests [attempt 2]Html Report (VSDrops) Download ❌ monotouch tests (iOS) [attempt 2]
Html Report (VSDrops) Download ❌ monotouch tests (tvOS) [attempt 2]
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated, and will be fixed in a different PR. |
No description provided.