Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcode16.3] Merge main into xcode16.3. #22276

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

rolfbjarne
Copy link
Member

No description provided.

mandel-macaque and others added 11 commits February 28, 2025 10:54
Looks like we landed code that should have never landed. But there is no
issues because the API is marked as experimental. It is the rgen binding
API.
In order to simplify the BindAs/BindFrom code, new methods were added to
the smart enums generated by bgen. We have to do the same in rgen.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
Add the missing notification configuration options for the
FieldAttribute. Do remember that we will use the analyzer to make sure
that those options are only used when the user passes the notification
flag.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
* Add missing availability attributes for .NET.
* Remove !.NET availability attributes / code.
* Remove redundant .NET availability attributes.
* Don't use deprecated APIs when there's an equivalent non-deprecated version
  available.

This is a step towards fixing #21185.
As with previous changes, move to use a method group instead of a lambda
with a using block.

We only add the new methods in those platforms that have the specifict
frameworks by using partial class. That way we keep the code cleaner
than with a collection of #if statements.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
…22265)

Implement the notifications helper class for those properties marked as
notifications. Code supports the same configuration options as bgen and
the test ensures that all configurations are tested:

1. No special config
2. Special args.
3. Special notification center.
4. Special args and notification center.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
We talked about it in a PR in which we agreed to have the same name and
have it as an overload.
Because installing simulators means running a C# project, which requires .NET to build.

Also improve the .NET version check systemdependencies.sh to not blindly try
to execute `dotnet`, but check for its presence first.

This fixes a couple of issues on bots that don't have .NET installed.
@rolfbjarne rolfbjarne requested a review from dalexsoto as a code owner March 3, 2025 14:31
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c13ebbb] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c13ebbb] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c13ebbb] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #c13ebbb] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #c13ebbb] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #c13ebbb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #c13ebbb] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❗ API diff for current PR / commit (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes)

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #c13ebbb] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 7 tests failed, 102 tests passed.

Failures

❌ dotnettests tests (iOS) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ introspection tests [attempt 2]

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ monotouch tests (iOS) [attempt 2]

1 tests failed, 7 tests passed.
  • monotouch-test/iOS - simulator/Release (NativeAOT, x64): Failed

Html Report (VSDrops) Download

❌ monotouch tests (tvOS) [attempt 2]

1 tests failed, 7 tests passed.
  • monotouch-test/tvOS - simulator/Release (NativeAOT, x64): Failed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c13ebbbba7095f2a4f6a7350b2a59e3247caa3f0 [PR build]

@rolfbjarne
Copy link
Member Author

Test failures are unrelated, and will be fixed in a different PR.

@rolfbjarne rolfbjarne merged commit 40b7d25 into xcode16.3 Mar 4, 2025
37 of 46 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/bump-main-in-xcode16.3-2025-03-03 branch March 4, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants