-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net10.0] Merge main into net10.0. #22328
base: net10.0
Are you sure you want to change the base?
Conversation
This has to be done in parts, because the Roslyn importer runs out of memory otherwise. Which also means I have no idea how many parts there will end up being. Partial fix for #17399.
* Simplify and expand how custom attributes are written into the xml description by not doing any fancy computation about the attribute properties, instead just write out what's in IL: any constructor arguments + parameter arguments. * Compare and show attributes for types and members. * Special-case [Experimental] attributes: * Adding an [Experimental] attribute to an existing type/member is a breaking change. * If a type or a member has an [Experimental] attribute, no changes within are breaking. * Removal of an obsolete type/member is a breaking change, so show it as such.
IsMultiRidBuild tracks if we are executing an inner build for a multi-rid case. With this approach, if the user specifies a value for EnableAssemblyILStripping it will still be honored. Otherwise, to ensure we don't duplicate assemblies when merging the app bundles due to a strip vs non-strip scenario, IL stripping for the multi-rid build is disabled by default. There have been past examples of optimizing in the outer-build: #12847 But because IL Stripping is contingent on the evaluation of other RID-specific properties, not sure if that is a feasible approach here. Fixes #17115 --------- Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
We're not binding Matter: #21177, so no need for xtro to report anything about it.
… the api definitions. (#22301) This fixes all of these availability warnings: > This call site is reachable on all platforms. 'FieldAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. > This call site is reachable on all platforms. 'iOSAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. > This call site is reachable on all platforms. 'MacAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. > This call site is reachable on all platforms. 'AdviceAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. This also required making sure we define the same conditional compilation symbols when compiling the api definitions as when we compile the rest of the sources.
…2311) This call is used in several places for the BindAs/BindFrom attribute. The factory method allows to pass the expected return type and a list or arguments. --------- Co-authored-by: Alex Soto <[email protected]>
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #7f06a47] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #7f06a47] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #7f06a47] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #7f06a47] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #7f06a47] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #7f06a47] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes) Pipeline on Agent |
❌ [CI Build #6b09b44] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #7f06a47] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
❌ [CI Build #7f06a47] Tests on macOS arm64 - Mac Sequoia (15) failed ❌Failed tests are:
Pipeline on Agent |
No description provided.