Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net10.0] Merge main into net10.0. #22328

Open
wants to merge 16 commits into
base: net10.0
Choose a base branch
from

Conversation

rolfbjarne
Copy link
Member

No description provided.

mandel-macaque and others added 15 commits March 5, 2025 20:51
This has to be done in parts, because the Roslyn importer runs out of memory otherwise.

Which also means I have no idea how many parts there will end up being.

Partial fix for #17399.
* Simplify and expand how custom attributes are written into the xml description
  by not doing any fancy computation about the attribute properties, instead just
  write out what's in IL: any constructor arguments + parameter arguments.
* Compare and show attributes for types and members.
* Special-case [Experimental] attributes:
  * Adding an [Experimental] attribute to an existing type/member  is a breaking change.
  * If a type or a member has an [Experimental] attribute, no changes within are breaking.
* Removal of an obsolete type/member is a breaking change, so show it as such.
IsMultiRidBuild tracks if we are executing an inner build for a
multi-rid case. With this approach, if the user specifies a value for
EnableAssemblyILStripping it will still be honored. Otherwise, to ensure
we don't duplicate assemblies when merging the app bundles due to a
strip vs non-strip scenario, IL stripping for the multi-rid build is
disabled by default.

There have been past examples of optimizing in the outer-build:
#12847
But because IL Stripping is contingent on the evaluation of other
RID-specific properties, not sure if that is a feasible approach here.

Fixes #17115

---------

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
We're not binding Matter: #21177,
so no need for xtro to report anything about it.
… the api definitions. (#22301)

This fixes all of these availability warnings:

> This call site is reachable on all platforms. 'FieldAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'iOSAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'MacAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.
> This call site is reachable on all platforms. 'AdviceAttribute' is supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later.

This also required making sure we define the same conditional compilation symbols
when compiling the api definitions as when we compile the rest of the sources.
…2311)

This call is used in several places for the BindAs/BindFrom attribute.
The factory method allows to pass the expected return type and a list or
arguments.

---------

Co-authored-by: Alex Soto <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 7, 2025

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7f06a47] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7f06a47] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7f06a47] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7f06a47] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7f06a47] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7f06a47] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #6b09b44] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 6b09b449b52ad9c85eb8208600f50395c824f1c0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #7f06a47] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #7f06a47] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 7f06a4780062ea79b90e82dc23c53420b6f0abdb [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants