Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on closing GC holes in bindings #22337

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

filipnavara
Copy link
Member

  • Generate GC.KeepAlive where necessary in bgen
  • Add analyzer to flag missing GC.KeepAlive calls
  • Update manual bindings to fix errors from the analyzer

Contributes to #10146

Copy link
Contributor

github-actions bot commented Mar 8, 2025

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

filipnavara and others added 2 commits March 8, 2025 01:09
- Add analyzer to flag missing GC.KeepAlive calls
- Update manual bindings to fix errors from the analyzer
Copy link
Member Author

@filipnavara filipnavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer is not fool-proof. For example, it doesn't understand generic parameters with constraints. The dataflow analysis could be done in more optimal way but I opted to get something simple and working first.

@filipnavara filipnavara marked this pull request as ready for review March 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant