Fixes situation where path to mlaunch has spaces
#22482
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry/Application Support/dnvm/dn/sdk] 6.0.425 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 6.0.428 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 8.0.303 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 8.0.402 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 9.0.100 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 9.0.101 [/Users/nat/Library/Application Support/dnvm/dn/sdk] 9.0.200 [/Users/nat/Library/Application Support/dnvm/dn/sdk] will work if the path to has spaces.
|
Although it does seem strange to me that |
|
Our CI doesn't work correctly when PRs are created from a fork, so I re-created this PR here: #22500, and I'll close this PR. |
rolfbjarne
added a commit
that referenced
this pull request
Mar 31, 2025
…paces. Fixes #22481. (#22500) Original PR #22482 contributed by @NatElkins. Fixes #22481. Co-authored-by: Nat Elkins <nathaniel.elkins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22481
I think the more correct thing to do would be to try and fix
Mlaunchdirectly, but trying to do something like:did not work, nor any other weird escaping things I tried.