Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] Cleanup variables and parameters a bit. #22490

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

rolfbjarne
Copy link
Member

  • Remove a few unused parameters.
  • Try to define parameters in a single location unless otherwise needed.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #3daa290] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #3daa290] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3daa290] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3daa290] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3daa290] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #3daa290] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #3daa290] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review March 28, 2025 07:18
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #3daa290] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 3daa2906f1e8f413f955d6a58aca2e62e9cc6af1 [PR build]

@rolfbjarne rolfbjarne merged commit 9bf9a88 into main Mar 28, 2025
47 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/devops-clean-variables branch March 28, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants