[Android] Fixed ListView items height are not proper in initial loading with HasUnevenRows set as True. #26841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
reviewed
Jan 6, 2025
src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ViewCellRenderer.cs
Outdated
Show resolved
Hide resolved
MartyIX
reviewed
Jan 6, 2025
| @@ -0,0 +1,65 @@ | |||
| using System.Collections.ObjectModel; | |||
|
|
|||
| namespace Maui.Controls.Sample.Issues | |||
There was a problem hiding this comment.
nit: Using file-scope namespace is IMO slightly better because one can see more code on smaller displays.
Suggested change
| namespace Maui.Controls.Sample.Issues | |
| namespace Maui.Controls.Sample.Issues; |
(Visual Studio has the neat feature of pressing ; here and it will convert the code for you.)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…ViewCellRenderer.cs Co-authored-by: MartyIX <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue details
The ListView item heights are incorrect when the HasUnevenRows property is set to true during the initial load, even though the height of each cell is explicitly defined.
Root cause
The cell's height is set incorrectly during the measure call.
Description of change
If a valid height is set for the cell, we can use it as the cell's height after converting it to pixels.
Reference
maui/src/Compatibility/Core/src/Android/Cells/ViewCellRenderer.cs
Line 276 in 76e5cd0
Validated the behaviour in the following platforms
Issues Fixed
Fixes #26820
Output
Before.mov
After.mov