You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TitleColor was used as the foreground color in the DataTemplate applied to the MenuItems. As a result, the color was applied to all items instead of being limited to the items in the NavigationView.
Description of Change
I removed the foreground color from the DataTemplate and applied the text color to the menu items in the NavigationView using the NavigationViewItemForeground. This resolved the issue, ensuring that the text color was applied exclusively to the menu items within the NavigationView, without affecting the items in the overflow menu presenter.
I have attached an image illustrating the behavior of the WinUI platform when applying the foreground color to a NavigationView item. The color was used exclusively for the items in the NavigationView, consistent with the behavior observed on other MAUI-supported platforms, such as Android, macOS, and iOS.
What does this look like when you change the system theme to dark mode?
@Redth, The menu item colors will change to white, similar to the behavior in WinUI, when the system theme is switched to Dark mode. I have attached a video for your reference.
The macOS UI Tests for TabbedPage keeps failing so... is something happening here? It seems weird, but want to make sure that this doesn't impact anything else
The macOS UI Tests for TabbedPage keeps failing so... is something happening here? It seems weird, but want to make sure that this doesn't impact anything else
@jfversluis, the UpdatedSelectionIndicatorProperly TabbedPage test appears to have failed due to the absence of a Mac screenshot. This screenshot seems to have already been added in the following PR #27028
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karthikraja-arumugam
added
the
partner/syncfusion
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #26754
Tested the behaviour in the following platforms
Screenshot
WinUI Reference