Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix for FontImageSource color is not applied to the Tab Icon on the TabbedPage #26888

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Dec 31, 2024

Root Cause of the issue

  • The FontImageSource icon color is not considered when applying the Icon's Foreground

Description of Change

  • The issue was resolved by storing the FontImageSource icon color in the IconColor property of the ViewModel. If IconColor is not null, the Foreground property retrieves the icon color and applies it to the icon's foreground. If IconColor is null, the Foreground property uses the SelectedForeground and UnselectedForeground values based on the IsSelected property and applies them to the icon's foreground.
  • Additionally, I have handled the dynamic updates to the Icon and IconColor properties in the OnPagePropertyChanged method

Issues Fixed

Fixes #26752

Test Case

Tested the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 31, 2024
Copy link
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 31, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 3, 2025 14:24
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FontImageSource color is not applied to the Tab Icon on Windows for the Tabbedpage
1 participant