Fix problem with null VirtualView in HybridVewHandler on iOS #26928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jan 4, 2025
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.iOS.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Leibowitz <[email protected]>
|
The correct syntax to mark the issue #26833 as fixed by this PR is:
(Your link does not work) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Do we know whats the case that this is called without a VirtualView? can we add a test? |
|
@mattleibow now should be good. U used |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
approved these changes
Jan 7, 2025
|
Maybe a test would be to show a page with a hybrid view, start some JS operation and then navigate back? How reliable is this? A manual call to DisconnectHandler may also be a trigger... @michalpobuta can you repro this issue in a simple page example where you call JS and then manually trigger a dispose before the JS finishes? |
rmarinho
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checking if Handler has container before using VirtualView which can crash app if is null
Issues Fixed
Fixes #26883