[Android] Fixed the SoftInputMode issues with modal pages #27553
+151
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
In the OnCreateDialog method,
CustomComponentDialog
is used to create the dialog, and its SoftInputMode defaults toAdjustUnspecified
. As a result, the behavior varies based on the layout:If a ScrollView is present, the window appears to resize.
Otherwise, it behaves as a pan.
Additionally, setting
SoftInputMode
at the sample level does not apply to the dialog.Description of Change
SoftInputMode
from the Context and apply it to thedialog
. This ensures consistent behavior and proper functionality, even when SoftInputMode is set at the sample level.Regressed PR
DecorView
was used for modal pages, but it has now been replaced byDialogFragment
for improvements.Issues Fixed
Tested the behaviour in the following platforms
Screenshot
ModalPageIssue.mov
ModalPageFix.mov