Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixed the SoftInputMode issues with modal pages #27553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ahamed-Ali
Copy link
Contributor

@Ahamed-Ali Ahamed-Ali commented Feb 4, 2025

Root Cause of the issue

In the OnCreateDialog method, CustomComponentDialog is used to create the dialog, and its SoftInputMode defaults to AdjustUnspecified. As a result, the behavior varies based on the layout:

  • If a ScrollView is present, the window appears to resize.

  • Otherwise, it behaves as a pan.

Additionally, setting SoftInputMode at the sample level does not apply to the dialog.

Description of Change

  • Retrieve the SoftInputMode from the Context and apply it to the dialog. This ensures consistent behavior and proper functionality, even when SoftInputMode is set at the sample level.

Regressed PR

Issues Fixed

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
ModalPageIssue.mov
ModalPageFix.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 4, 2025
Copy link
Contributor

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@vishnumenon2684 vishnumenon2684 added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 4, 2025
@Ahamed-Ali Ahamed-Ali marked this pull request as ready for review February 4, 2025 13:49
@Copilot Copilot bot review requested due to automatic review settings February 4, 2025 13:49
@Ahamed-Ali Ahamed-Ali requested a review from a team as a code owner February 4, 2025 13:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27242.cs:35

  • The method name 'WindowSoftInputModeAdjustSetToPanForModalpage' should be 'WindowSoftInputModeAdjustSetToPanForModalPage' to maintain consistency in naming conventions.
public void WindowSoftInputModeAdjustSetToPanForModalpage()
@PureWeen PureWeen added this to the .NET 9 SR5 milestone Feb 11, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-modal community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android 🤖
Projects
Status: Todo
4 participants