Make iOS WebView delegates virtual #27601
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
requested review from
StephaneDelcroix and
mattleibow
and removed request for
a team
|
🚨 API change(s) detected @davidbritch FYI |
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
jsuarezruiz
reviewed
Feb 6, 2025
| @@ -23,7 +23,7 @@ public MauiWebViewNavigationDelegate(IWebViewHandler handler) | |||
| } | |||
|
|
|||
| [Export("webView:didFinishNavigation:")] | |||
| public void DidFinishNavigation(WKWebView webView, WKNavigation navigation) | |||
| public virtual void DidFinishNavigation(WKWebView webView, WKNavigation navigation) | |||
There was a problem hiding this comment.
Needs more changes in publicAPIs (Catalyst):
D:\a\_work\1\s\src\Core\src\Platform\iOS\MauiWebViewNavigationDelegate.cs(102,23): error RS0016: Symbol 'DecidePolicy' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\Platform\iOS\MauiWebViewNavigationDelegate.cs(80,23): error RS0016: Symbol 'DidFailProvisionalNavigation' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\Platform\iOS\MauiWebViewNavigationDelegate.cs(59,23): error RS0016: Symbol 'DidFailNavigation' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\Platform\iOS\MauiWebViewNavigationDelegate.cs(26,23): error RS0016: Symbol 'DidFinishNavigation' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\PublicAPI\net-maccatalyst\PublicAPI.Shipped.txt(1722,1): error RS0017: Symbol 'Microsoft.Maui.Platform.MauiWebViewNavigationDelegate.DecidePolicy(WebKit.WKWebView! webView, WebKit.WKNavigationAction! navigationAction, System.Action<WebKit.WKNavigationActionPolicy>! decisionHandler) -> void' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\PublicAPI\net-maccatalyst\PublicAPI.Shipped.txt(1723,1): error RS0017: Symbol 'Microsoft.Maui.Platform.MauiWebViewNavigationDelegate.DidFailNavigation(WebKit.WKWebView! webView, WebKit.WKNavigation! navigation, Foundation.NSError! error) -> void' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\PublicAPI\net-maccatalyst\PublicAPI.Shipped.txt(1724,1): error RS0017: Symbol 'Microsoft.Maui.Platform.MauiWebViewNavigationDelegate.DidFailProvisionalNavigation(WebKit.WKWebView! webView, WebKit.WKNavigation! navigation, Foundation.NSError! error) -> void' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
D:\a\_work\1\s\src\Core\src\PublicAPI\net-maccatalyst\PublicAPI.Shipped.txt(1725,1): error RS0017: Symbol 'Microsoft.Maui.Platform.MauiWebViewNavigationDelegate.DidFinishNavigation(WebKit.WKWebView! webView, WebKit.WKNavigation! navigation) -> void' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net10.0-maccatalyst18.2]
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes the
MauiWebViewNavigationDelegatemethods virtual so people can override these.Issues Fixed
Fixes #7551