Add build check result errors into the list of build submission IDs that have logged error

[JaynieBai]

Fixes #10071

Context

While building with buildcheck enabled and MSBUILDNOINPROCNODE=1
Severity of the rule set to Error, does not reported to the all build:

This is since buildcheck error is not added into the _warningsAsErrorsByProject, WarningsAsErrors == null && _warningsAsErrorsByProject == null is true all the time. so HasBuildSubmissionLoggedErrors always return false.

msbuild/src/Build/BackEnd/Components/Logging/LoggingService.cs

Lines 578 to 586 in 843bfa5

	{
	// Warnings as errors are not tracked if the user did not specify to do so
	if (WarningsAsErrors == null && _warningsAsErrorsByProject == null)
	{
	return false;
	}
	// Determine if any of the event sinks have logged an error with this submission ID
	return _buildSubmissionIdsThatHaveLoggedErrors?.Contains(submissionId) == true;

Changes Made

when buildEventArgs is BuildErrorEventArgs, treat BuildErrorEventArgs' related warnings as errors

Testing

Notes

[JaynieBai]

Will add a test after figured out the reason of flaky test SampleAnalyzerIntegrationTest #10036

[JanKrivanek]

We should probably handle the warning + ShouldTreatWarningAsError as well

[JaynieBai]

So there is one condition build with -err:BC0101