always print auth messages in TL, regardless of verbosity #11551
+30
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
special-auth-messages
branch
from
7c7d9d8 to
26a168c
Compare
| RenderImmediateMessage(message); | ||
| return; | ||
| } | ||
|
|
||
| if (Verbosity > LoggerVerbosity.Quiet) | ||
| { | ||
| // Show immediate messages to the user. |
There was a problem hiding this comment.
Suggested change
| // Show immediate messages to the user. |
Comment on lines
-2
to
-6
| directory/[1mfile[m(1,2,3,4): [33;1mwarning[m [33;1mAA0000[m: | ||
| A | ||
| Multi | ||
| Line | ||
| Warning! |
There was a problem hiding this comment.
What happened to these warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/sdk#47602
Context
With
NuGetInteractive=truebeing passed in more scenarios as of dotnet/sdk#47226, the default verbosity fordotnet runis nowminimalfor user-present scenarios - that's gross.Changes Made
Broadly what I'm trying to do here is not require passing
-v mto loggers to get the authentication-related messages. Right nowdotnet rundoes this and it's quite noisy compared to previous behavior. This changed because recently I made the SDK start passing--interactivewhen the user is at the keyboard (similar logic to Terminal Logger's own enablement), anddotnet runhas logic to force verbosity to minimal when that happens so that the auth messages print where a user can see them.I kind of think of auth messages as messages that we should write regardless of verbosity (like errors are), so this is a step down that path for TL.
This change ensures that auth messages are always written in the TL experience, as immediate messages.
If this is accepted, then the SDK could remove the special case it currently has.
Testing
Updated snapshot baselines, manual testing.
Notes