Add benchmark for File.Move
#2437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamsitnik should we consider categorizing System.IO benchmarks by the filesystem they are running against? The results might differ a lot if the drive is NTFS, EXT4, EXFAT, etc., even within the same OS and .NET version. |
danmoseley
reviewed
May 14, 2022
| { | ||
| if (File.Exists(_moveDestination)) | ||
| { | ||
| File.Delete(_moveDestination); |
There was a problem hiding this comment.
I believe File.Delete does not need protecting with File.Exists
There was a problem hiding this comment.
I have taken the procedure from other methods in the class.
adamsitnik
reviewed
May 16, 2022
| private string _moveSource; | ||
| private string _moveDestination; | ||
|
|
||
| [IterationSetup(Target = nameof(Move))] |
There was a problem hiding this comment.
we try not to use IterationSetup if possible: https://github.com/dotnet/performance/blob/main/docs/microbenchmark-design-guidelines.md#iterationsetup
In case of move benchmark, we could just swap the files:
private ulong counter;
[Benchmark]
public void Move()
{
if (counter++ % 2 == 0)
File.Move(_moveSource, _moveDestination);
else
File.Move(_moveDestination, _moveSource);
}
|
@deeprobin do you plan to address feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to introduce a benchmark to measure the performance of
File.Move.See dotnet/runtime#65092
/cc @adamsitnik