Issue #75070 (Dotnet Runtime) - Add a performance microbenchmark for … #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the new PriorityQueue DequeueEnqueue method to help monitor for performance regressions
…orityQueueSize_DequeueEnqueue_PerformanceRegressionBenchmark
| @@ -106,5 +106,30 @@ public void K_Max_Elements() | |||
| queue.Dequeue(); | |||
| } | |||
| } | |||
|
|
|||
| [Benchmark] | |||
| public void KMaxPriorityQueueSize_DequeueEnqueue_PerformanceRegressionBenchmark() | |||
There was a problem hiding this comment.
IIRC this isn't really computing any max or min elements, since unlike EnqueueDequeue, DequeueEnqueue is never comparing the extracted min heap entry with the inserted entry. The PerformanceRegressionBenchmark suffix is redundant, since that's what all benchmarks in this repo are intended for. Recommend keeping the benchmark name ambiguous:
Suggested change
| public void KMaxPriorityQueueSize_DequeueEnqueue_PerformanceRegressionBenchmark() | |
| public void DequeueEnqueue() |
…equeueEnqueue per the PR recommendation
eiriktsarpalis
approved these changes
Sep 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the new PriorityQueue DequeueEnqueue method to help monitor for performance regressions
Serves as a performance regression check benchmark for the new
PriorityQueueDequeueEnqueuepublic api method added as part of this dotnet runtime issue dotnet/runtime#75070