Expunged all references to GoodLinq #3488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markples
reviewed
Nov 13, 2023
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/CPUAnalysis/MarkPhaseAnalysis.cs
Outdated
Show resolved
Hide resolved
…s/MarkPhaseAnalysis.cs Thanks for catching this. Co-authored-by: Mark Plesko <[email protected]>
markples
reviewed
Nov 13, 2023
Comment on lines
+36
to
+69
| public static double EagerSum<TSource>(this IEnumerable<TSource> data, Func<TSource, double> map) | ||
| { | ||
| double sum = 0; | ||
| if (data == null || data.Count() == 0) | ||
| { | ||
| return sum; | ||
| } | ||
|
|
||
| foreach(var sourceItem in data) | ||
| { | ||
| sum += (double)map(sourceItem); | ||
| } | ||
|
|
||
| return sum; | ||
| } | ||
|
|
||
| public static double EagerAverage<TSource>(this IEnumerable<TSource> data, Func<TSource, double> map) | ||
| { | ||
| int count = data.Count(); | ||
| if (data == null || count == 0) | ||
| { | ||
| return double.NaN; | ||
| } | ||
|
|
||
| double sum = 0; | ||
| foreach(var sourceItem in data) | ||
| { | ||
| sum += (double)map(sourceItem); | ||
| } | ||
|
|
||
| return sum / count; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The standard Linq methods are already eager for these two. These differ from Linq
- in their handling of null (no exception)
- Average() returning NaN instead of throwing. (though there are Linq overloads that takes enumerables of nullables, and if the enumerable has no nonnull values (empty enumerable is a degenerate case of this) returns
null) - calling
Count()rather than counting during theforeach- if the enumerable is a List this won't matter, but for others it could enumerate twice - Linq uses checked arithmetic
markples
reviewed
Nov 13, 2023
src/benchmarks/gc/GC.Infrastructure/GC.Analysis.API/GCAnalysis/GCSummarization.cs
Outdated
Show resolved
Hide resolved
…/GCSummarization.cs Co-authored-by: Mark Plesko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed GoodLinq to EagerLinq and added it as a part of the System.Linq namespace as an extension method.