Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more Fixes and Robustness Improvements for the ASP.NET Runs #4067

Merged
merged 15 commits into from
Jun 27, 2024
Merged

Added more Fixes and Robustness Improvements for the ASP.NET Runs #4067

merged 15 commits into from
Jun 27, 2024

Conversation

mrsharm
Copy link
Member

@mrsharm mrsharm commented Mar 19, 2024 •
edited
Loading

  • Update the connection look up strategy to ping the aspnet machines.
  • Fix up the failure yaml and the filters.
  • Add command line to the log file.
  • If the machines reboots, restart the entire run.
  • Adding Linux container scenarios as a csv.
  • Check in ASP.NET to see if artifacts such as GCLog / Traces are available.
  • Updated time specified for the ASP.NET machines to restart from 9 to 10 minutes.
  • Consider the run a failure if the request traces are not downloaded.

Partially addresses: #3969

mrsharm and others added 12 commits March 19, 2024 14:55
Maoni0
Maoni0 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using these changes for a while and other than the sleep time everything seemed to work fine.

@mrsharm mrsharm merged commit 91e3c4e into dotnet:main Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@cshung cshung Awaiting requested review from cshung

@markples markples Awaiting requested review from markples

@mangod9 mangod9 Awaiting requested review from mangod9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsharm @Maoni0