Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out output.path check logic for aspnetbenchmarks #4315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

comment out output.path check logic for aspnetbenchmarks #4315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d08cfa
comment out output.path check logic for aspnetbenchmarks
VincentBu Jul 16, 2024
d21bbda
get rid of output.path check logic
VincentBu Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .../GC.Infrastructure/GC.Infrastructure.Core/Configurations/ASPNetBenchmark.Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,11 @@ public static ASPNetBenchmarksConfiguration Parse(string path)
throw new ArgumentNullException($"{nameof(ASPNetBenchmarksConfigurationParser)}: {nameof(configuration.Output)} is null. Check the syntax of the configuration.");
}

if (string.IsNullOrEmpty(configuration.Output.Path))
{
throw new ArgumentNullException($"{nameof(ASPNetBenchmarksConfigurationParser)}: {nameof(configuration.Output.Path)} is null or empty. Please specify an output path.");
}
// configuration.Output.Path can be null when creating suites for ene to end run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of these lines.

//if (string.IsNullOrEmpty(configuration.Output.Path))
//{
// throw new ArgumentNullException($"{nameof(ASPNetBenchmarksConfigurationParser)}: {nameof(configuration.Output.Path)} is null or empty. Please specify an output path.");
//}

if (configuration.Environment == null)
{
Expand Down