Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC reports notebook - redo color families #4389

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GC reports notebook - redo color families #4389

wants to merge 5 commits into from

Conversation

markples
Copy link
Member

@markples markples commented Aug 9, 2024

Color families:

  • Add general helpers for color families and series titles
  • Make the color family selection criteria configurable

Misc:

  • Fix DataPresenter.Clear to also clear the Debug variable
  • Make the scatter mode and width configurable on charts

@markples markples requested a review from mrsharm August 9, 2024 23:39
@markples markples self-assigned this Aug 9, 2024
mrsharm
mrsharm approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@mrsharm mrsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LoopedBard3
Copy link
Member

@markples, is this ready to merge? If so, feel free to if you have the necessary permissions, otherwise let me know and I can merge this. Same for #4388.

@markples
Copy link
Member Author

@markples, is this ready to merge? If so, feel free to if you have the necessary permissions, otherwise let me know and I can merge this. Same for #4388.

This one should be, but I should pull and retest locally before doing so. #4388 has a question that I need to get back to. Thanks for the reminder - I should definitely get these finished.

@LoopedBard3
Copy link
Member

Sounds good, feel free to leave a message or ping me directly when either or both are ready 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsharm mrsharm mrsharm approved these changes

Assignees

@markples markples

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markples @LoopedBard3 @mrsharm