-
Notifications
You must be signed in to change notification settings - Fork 230
Remove Razor EA For Roslyn #11510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove Razor EA For Roslyn #11510
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
9abb389
Move naming
e4cb0ac
Fix build
3ef44b4
Remove ProjectEngineHost project by moving things into
315658b
Update resource files
590367c
Fix compilation
1413236
Bump local packages
a3eeb9f
Respond to changes in roslyn EA
0f09a56
Merge branch 'main' into remove_razor_ea
2a57a43
Nullability and usings
fdacf95
Remove local nuget
059341f
Final changes
404c321
Compiling and ready for testing. Still failing
f265359
Merge branch 'main' into remove_razor_ea
46a9970
Merge branch 'main' into remove_razor_ea
4c4871b
Don't export stateless service
1eb80e6
Merge branch 'main' into remove_razor_ea
f964da7
Remove using
5bce5e4
Working...
5cc494e
Package the extension into a nupkg
24381ea
Remove Nuget.config changes
951f9ea
Update layering doc and undo unnecessary changes
87517c1
Remove file that was meant to be removed...
26ff153
change to sealed class
9c18bad
Rename files
21fb54c
Remove file
d1c4f2b
Fix namespaces
d9a7e5a
Remove test project and merge into workspaces
24efc13
Remove last references to Microsoft.CodeAnalysis.Razor.ProjectEngineHost
1f654eb
Restore PrivateAssets
138491f
Merge branch 'main' into remove_razor_ea
9c1bfd6
Add back UrlDecoderTests
bd88e39
Use collection expressions
7cda646
Remove unused type
003e335
Merge branch 'remove_razor_ea' of https://github.com/ryzngard/razor i…
76ee9d5
Remove duplicated types
f7a49db
Reuse types
6c7b39b
Fix HashSet usage and null out when done
be26139
Allow multiple updates to be applied since we allow that in the vs co…
39a5c88
Consolidate code
8758737
Handle null response
ba48169
Use real versions
b70298f
Update namespaces
6fa2618
Update Version.details.xml
9d86df7
Update with darc and fix source build
91ba66c
Skip failing test
e812dab
Unblock for now
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of a better name, and I don't think it matters, but I would like to state for the record that
Microsoft.VisualStudio.RazorExtensionis a visual studio extension andMicrosoft.VisualStudioCode.RazorExtensionis not a visual studio code extension 😛There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the name either. It's a bit too generic, and MS.VS.RazorExtension is not something to emulate. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea... I didn't love writing it but wasn't able to come up with an alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. 😢