Use auto properties

src/Analyzers/Core/Analyzers/DiagnosticCustomTags.cs

@@ -14,56 +14,50 @@
 {
     private static readonly string s_enforceOnBuildNeverTag = EnforceOnBuild.Never.ToCustomTag();
 
-    private static readonly string[] s_microsoftCustomTags = [WellKnownDiagnosticTags.Telemetry];
-    private static readonly string[] s_editAndContinueCustomTags = [WellKnownDiagnosticTags.EditAndContinue, WellKnownDiagnosticTags.Telemetry, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag];
-    private static readonly string[] s_unnecessaryCustomTags = [WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.Telemetry];
-    private static readonly string[] s_notConfigurableCustomTags = [WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry];
-    private static readonly string[] s_unnecessaryAndNotConfigurableCustomTags = [WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry];
-
     public static string[] Microsoft
     {
         get
         {
-            Assert(s_microsoftCustomTags, WellKnownDiagnosticTags.Telemetry);
-            return s_microsoftCustomTags;
+            Assert(field, WellKnownDiagnosticTags.Telemetry);
+            return field;
         }
-    }
+    } = [WellKnownDiagnosticTags.Telemetry];
 
     public static string[] EditAndContinue
     {
         get
         {
-            Assert(s_editAndContinueCustomTags, WellKnownDiagnosticTags.EditAndContinue, WellKnownDiagnosticTags.Telemetry, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag);
-            return s_editAndContinueCustomTags;
+            Assert(field, WellKnownDiagnosticTags.EditAndContinue, WellKnownDiagnosticTags.Telemetry, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag);
+            return field;
         }
-    }
+    } = [WellKnownDiagnosticTags.EditAndContinue, WellKnownDiagnosticTags.Telemetry, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag];
 
     public static string[] Unnecessary
     {
         get
         {
-            Assert(s_unnecessaryCustomTags, WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.Telemetry);
-            return s_unnecessaryCustomTags;
+            Assert(field, WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.Telemetry);
+            return field;
         }
-    }
+    } = [WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.Telemetry];
 
     public static string[] NotConfigurable
     {
         get
         {
-            Assert(s_notConfigurableCustomTags, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry);
-            return s_notConfigurableCustomTags;
+            Assert(field, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry);
+            return field;
         }
-    }
+    } = [WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry];
 
     public static string[] UnnecessaryAndNotConfigurable
     {
         get
         {
-            Assert(s_unnecessaryAndNotConfigurableCustomTags, WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry);
-            return s_unnecessaryAndNotConfigurableCustomTags;
+            Assert(field, WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry);
+            return field;
         }
-    }
+    } = [WellKnownDiagnosticTags.Unnecessary, WellKnownDiagnosticTags.NotConfigurable, s_enforceOnBuildNeverTag, WellKnownDiagnosticTags.Telemetry];
 
     [Conditional("DEBUG")]
     private static void Assert(string[] customTags, params string[] tags)

src/EditorFeatures/Core/ChangeSignature/AbstractChangeSignatureCommandHandler.cs

@@ -8,7 +8,6 @@
 using Microsoft.CodeAnalysis.Editor.Shared.Utilities;
 using Microsoft.CodeAnalysis.Editor.Undo;
 using Microsoft.CodeAnalysis.Notification;
-using Microsoft.CodeAnalysis.Options;
 using Microsoft.CodeAnalysis.Shared.Extensions;
 using Microsoft.VisualStudio.Commanding;
 using Microsoft.VisualStudio.Text;

src/EditorFeatures/Core/InlineRename/InlineRenameSession.cs

@@ -55,7 +55,6 @@ internal partial class InlineRenameSession : IInlineRenameSession, IFeatureContr
 
     private bool _dismissed;
     private bool _isApplyingEdit;
-    private string _replacementText;
     private readonly Dictionary<ITextBuffer, OpenTextBufferManager> _openTextBuffers = [];
 
     /// <summary>
@@ -74,13 +73,10 @@ internal partial class InlineRenameSession : IInlineRenameSession, IFeatureContr
     /// </summary>
     public string ReplacementText
     {
-        get
-        {
-            return _replacementText;
-        }
+        get;
         private set
         {
-            _replacementText = value;
+            field = value;
             ReplacementTextChanged?.Invoke(this, EventArgs.Empty);
         }
     }

src/EditorFeatures/Core/IntelliSense/ModelComputation.cs

@@ -32,14 +32,13 @@ internal class ModelComputation<TModel> where TModel : class
     #region Fields that can only be accessed from the foreground thread
 
     private readonly IController<TModel> _controller;
-    private readonly TaskScheduler __taskScheduler;
 
     private TaskScheduler _taskScheduler
     {
         get
         {
             ThreadingContext.ThrowIfNotOnUIThread();
-            return __taskScheduler;
+            return field;
         }
     }
 
@@ -62,7 +61,7 @@ public ModelComputation(
     {
         ThreadingContext = threadingContext;
         _controller = controller;
-        __taskScheduler = computationTaskScheduler;
+        _taskScheduler = computationTaskScheduler;
 
         _stopTokenSource = new CancellationTokenSource();
         _stopCancellationToken = _stopTokenSource.Token;

src/Features/Core/Portable/Completion/CompletionContext.cs

@@ -22,9 +22,6 @@ public sealed class CompletionContext
 {
     private readonly SegmentedList<CompletionItem> _items = [];
 
-    private CompletionItem? _suggestionModeItem;
-    private bool _isExclusive;
-
     internal CompletionProvider Provider { get; }
 
     /// <summary>
@@ -89,15 +86,15 @@ public bool IsExclusive
     {
         get
         {
-            return _isExclusive && !Provider.IsExpandItemProvider;
+            return field && !Provider.IsExpandItemProvider;
         }
 
         set
         {
             if (value)
                 Debug.Assert(!Provider.IsExpandItemProvider);
 
-            _isExclusive = value;
+            field = value;
         }
     }
 
@@ -198,10 +195,7 @@ public void AddItems(IEnumerable<CompletionItem> items)
     /// </summary>
     public CompletionItem? SuggestionModeItem
     {
-        get
-        {
-            return _suggestionModeItem;
-        }
+        get;
 
         set
         {
@@ -210,7 +204,7 @@ public CompletionItem? SuggestionModeItem
                 value = FixItem(value);
             }
 
-            _suggestionModeItem = value;
+            field = value;
         }
     }
 

src/Features/Core/Portable/Completion/CompletionDescription.cs

@@ -13,8 +13,6 @@ namespace Microsoft.CodeAnalysis.Completion;
 /// </summary>
 public sealed class CompletionDescription
 {
-    private string? _text;
-
     /// <summary>
     /// The <see cref="CompletionDescription"/> used when there is no description.
     /// </summary>
@@ -63,12 +61,12 @@ public string Text
     {
         get
         {
-            if (_text == null)
+            if (field == null)
             {
-                Interlocked.CompareExchange(ref _text, string.Concat(TaggedParts.Select(p => p.Text)), null);
+                Interlocked.CompareExchange(ref field, string.Concat(TaggedParts.Select(p => p.Text)), null);
             }
 
-            return _text;
+            return field;
         }
-    }
+    } = null!;
 }

src/Features/Core/Portable/QuickInfo/QuickInfoSection.cs

@@ -37,28 +37,26 @@ private QuickInfoSection(string? kind, ImmutableArray<TaggedText> taggedParts)
     public static QuickInfoSection Create(string? kind, ImmutableArray<TaggedText> taggedParts)
         => new(kind, taggedParts);
 
-    private string? _text;
-
     /// <summary>
     /// The text of the section without tags.
     /// </summary>
     public string Text
     {
         get
         {
-            if (_text == null)
+            if (field == null)
             {
                 if (TaggedParts.Length == 0)
                 {
-                    _text = string.Empty;
+                    field = string.Empty;
                 }
                 else
                 {
-                    Interlocked.CompareExchange(ref _text, string.Concat(TaggedParts.Select(t => t.Text)), null);
+                    Interlocked.CompareExchange(ref field, string.Concat(TaggedParts.Select(t => t.Text)), null);
                 }
             }
 
-            return _text;
+            return field;
         }
-    }
+    } = null!;
 }

src/VisualStudio/Core/Def/ChangeSignature/AddParameterDialogViewModel.cs

@@ -59,13 +59,12 @@ public AddParameterDialogViewModel(Document document, int positionForTypeBinding
 
     public bool TypeBinds => !TypeSymbol!.IsErrorType();
 
-    private bool _isRequired;
     public bool IsRequired
     {
-        get => _isRequired;
+        get;
         set
         {
-            if (SetProperty(ref _isRequired, value))
+            if (SetProperty(ref field, value))
             {
                 NotifyPropertyChanged(nameof(IsOptional));
 
@@ -83,10 +82,10 @@ public bool IsRequired
 
     public bool IsOptional
     {
-        get => !_isRequired;
+        get => !IsRequired;
         set
         {
-            if (_isRequired == value)
+            if (IsRequired == value)
             {
                 IsRequired = !value;
             }
@@ -106,19 +105,17 @@ public bool IsOptional
     public Visibility TypeDoesNotBindImage { get; set; }
     public Visibility TypeDoesNotParseOrInvalidTypeImage { get; set; }
     public Visibility TypeIsEmptyImage { get; set; }
-
-    private string _verbatimTypeName = string.Empty;
     public string VerbatimTypeName
     {
-        get => _verbatimTypeName;
+        get;
         set
         {
-            if (SetProperty(ref _verbatimTypeName, value))
+            if (SetProperty(ref field, value))
             {
                 SetCurrentTypeTextAndUpdateBindingStatus(value);
             }
         }
-    }
+    } = string.Empty;
 
     private bool _isVoidParameterType;
 

src/VisualStudio/Core/Def/ChangeSignature/ChangeSignatureDialogViewModel.cs

@@ -225,9 +225,9 @@ private bool EditableParameterSelected(out int index)
 
     internal void Remove()
     {
-        if (AllParameters[_selectedIndex!.Value] is AddedParameterViewModel)
+        if (AllParameters[SelectedIndex!.Value] is AddedParameterViewModel)
         {
-            var parameterToRemove = AllParameters[_selectedIndex!.Value];
+            var parameterToRemove = AllParameters[SelectedIndex!.Value];
 
             if (!_parametersWithoutDefaultValues.Remove(parameterToRemove))
             {
@@ -236,7 +236,7 @@ internal void Remove()
         }
         else
         {
-            AllParameters[_selectedIndex!.Value].IsRemoved = true;
+            AllParameters[SelectedIndex!.Value].IsRemoved = true;
         }
 
         UpdateNameConflictMarkers();
@@ -245,7 +245,7 @@ internal void Remove()
 
     internal void Restore()
     {
-        AllParameters[_selectedIndex!.Value].IsRemoved = false;
+        AllParameters[SelectedIndex!.Value].IsRemoved = false;
         UpdateNameConflictMarkers();
         RemoveRestoreNotifyPropertyChanged();
     }
@@ -507,23 +507,19 @@ private bool IsDisabled(ParameterViewModel parameterViewModel)
         return _disabledParameters.Contains(parameterViewModel);
     }
 
-    private int? _selectedIndex;
     public int? SelectedIndex
     {
-        get
-        {
-            return _selectedIndex;
-        }
+        get;
 
         set
         {
             var newSelectedIndex = value == -1 ? null : value;
-            if (newSelectedIndex == _selectedIndex)
+            if (newSelectedIndex == field)
             {
                 return;
             }
 
-            _selectedIndex = newSelectedIndex;
+            field = newSelectedIndex;
 
             NotifyPropertyChanged(nameof(CanMoveUp));
             NotifyPropertyChanged(nameof(MoveUpAutomationText));

src/VisualStudio/Core/Def/CommonControls/MemberSelectionViewModel.cs

@@ -46,17 +46,16 @@ public MemberSelectionViewModel(
 
     public bool ShowCheckDependentsButton { get; }
     public bool ShowPublicButton { get; }
-    public bool ShowMakeAbstract => _members.Any(m => m.IsMakeAbstractCheckable);
+    public bool ShowMakeAbstract => Members.Any(m => m.IsMakeAbstractCheckable);
     public ImmutableArray<MemberSymbolViewModel> CheckedMembers => Members.WhereAsArray(m => m.IsChecked && m.IsCheckable);
 
-    private ImmutableArray<MemberSymbolViewModel> _members;
     public ImmutableArray<MemberSymbolViewModel> Members
     {
-        get => _members;
+        get;
         set
         {
-            var oldMembers = _members;
-            if (SetProperty(ref _members, value))
+            var oldMembers = field;
+            if (SetProperty(ref field, value))
             {
                 // If we have registered for events before, remove the handlers
                 // to be a good citizen in the world 
@@ -68,7 +67,7 @@ public ImmutableArray<MemberSymbolViewModel> Members
                     }
                 }
 
-                foreach (var member in _members)
+                foreach (var member in field)
                 {
                     member.PropertyChanged += MemberPropertyChangedHandler;
                 }

src/VisualStudio/Core/Def/CommonControls/NewTypeDestinationSelectionViewModel.cs

@@ -87,18 +87,17 @@ public string FileName
         set { SetProperty(ref _fileName, value); }
     }
 
-    private NewTypeDestination _destination = NewTypeDestination.NewFile;
     public NewTypeDestination Destination
     {
-        get { return _destination; }
+        get;
         set
         {
-            if (SetProperty(ref _destination, value))
+            if (SetProperty(ref field, value))
             {
                 NotifyPropertyChanged(nameof(FileNameEnabled));
             }
         }
-    }
+    } = NewTypeDestination.NewFile;
 
     internal bool TrySubmit([NotNullWhen(returnValue: false)] out string? message)
     {