Update SVE instructions that writes to GC regs #112389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
a74nh
reviewed
Feb 11, 2025
| @@ -1087,6 +1087,22 @@ bool emitter::emitInsMayWriteToGCReg(instrDesc* id) | |||
| case IF_SR_1A: // SR_1A ................ ...........ttttt Rt (dc zva, mrs) | |||
| return ins == INS_mrs_tpid0; | |||
|
|
|||
| // Below SVE instructions write to GPR and hence GC reg | |||
There was a problem hiding this comment.
How did you figure out this list? Just want to make sure we've got all of them
There was a problem hiding this comment.
I just went through the instrsarm64sve.h and went over the instructions that has GPR as destination register and added them to this list.
a74nh
approved these changes
Feb 11, 2025
|
@dotnet/jit-contrib |
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sample diff:
|
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
approved these changes
Feb 11, 2025
|
I do see some new failures emerged after the original one was passing. I will look little more to make sure all are addressed before merging this PR: |
|
alright, so the issue is some kind of timeout that is getting triggered for all the partitions of the test and not anything underlying. I will go ahead and merge this one and follow up on the above mentioned issue. |
|
Opened #112463 to track it. |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 12, 2025
* main: [Android] Run CoreCLR functional tests on Android (dotnet#112283) [LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. (dotnet#112229) Fix suspicious code fragments (dotnet#112384) `__ComObject` doesn't support dynamic interface map (dotnet#112375) Native DLLs: only load imported DLLs from System32 (dotnet#112359) [main] Update dependencies from dotnet/roslyn (dotnet#112314) Update SVE instructions that writes to GC regs (dotnet#112389) Bring up android+coreclr windows build. (dotnet#112256) Never use heap for return buffers (dotnet#112060) Wait to complete the test before releasing the agile reference. (dotnet#112387) Prevent returning disposed HTTP/1.1 connections to the pool (dotnet#112383) Fingerprint dotnet.js if writing import map to html is enabled (dotnet#112407) Remove duplicate definition of CORECLR_HOSTING_API_LINKAGE (dotnet#112096) Update the exception message to reflect current behavior. (dotnet#112355) Use enum for frametype not v table (dotnet#112166) Enable AltJits build for LoongArch64 and RiscV64 (dotnet#110282) Guard members of MonoType union & fix related bugs (dotnet#111645) Add optional hooks for debugging OpenSSL memory allocations (dotnet#111539) JIT: Optimize struct parameter register accesses in the backend (dotnet#110819) NativeAOT: Cover more opcodes in type preinitializer (dotnet#112073)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't update the method
emitInsMayWriteToGCRegwhen we added SVE instructions. This method keeps track if we will be writing into GPR registers and if so, need to remove that register from GC tracking.Fixes: #112362
@dotnet/arm64-contrib