Move protected member check in the class #104118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @hoyosjs |
19 tasks
jkoritzinsky
approved these changes
Jun 27, 2024
This was referenced Jun 28, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @gwr for finding a debug build issue with illumos cross setup (gcc 8.4). #34944 (comment)
This ensures that the protected member is accessed within the class to make older gcc happy (note the existing syntax is legal in C++ because of
friend class CheckedIteratorBase<SBuffer>and gcc 9 onwards are fine with it but we are stuck with gcc 8.4 in rootfs for now illumos/sysroot#3).failing build off of
main: https://github.com/am11/CrossRepoCITesting/actions/runs/9701959060/job/26776715403working build with this patch: https://github.com/am11/CrossRepoCITesting/actions/runs/9702500203/job/26778504623