Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] fix stack 2x2 tensor along dimension 1 #110053

Open
wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2024

Backport of #108620 to release/9.0-staging

/cc @tannergooding @kasperk81

Customer Impact

  • Customer reported
  • Found internally

#108615. Incorrect results will be computed for StackAlongDimension

Regression

  • Yes
  • No

This is a net new and in-preview API for .NET 9

Testing

Additional tests covering the relevant scenario were added.

Risk

Low. This is a net new API in .NET 9 and shipped as experimental.

Fixing it will help ensure developers can use the feature and provide feedback as part of stabilizing the API surface.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

@tannergooding tannergooding added the Servicing-consider Issue for next servicing release review label Nov 21, 2024
@tannergooding
Copy link
Member

CC. @jeffhandley

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @artl93

@tannergooding
Copy link
Member

Removed servicing-consider temporarily as @MihaZupan pointed out that another line needs updating for the latter method to be correct. This likely means we also need another test to cover that overload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants