Remove 2 more casting helper method frames #110064
Open
+29
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
reviewed
Nov 21, 2024
| [MethodImpl(MethodImplOptions.InternalCall)] | ||
| private static extern object IsInstanceOfAny_NoCacheLookup(void* toTypeHnd, object obj); | ||
| [LibraryImport(RuntimeHelpers.QCall)] | ||
| private static partial bool IsInstanceOf_NoCacheLookup(void *toTypeHnd, bool throwCastException, ObjectHandleOnStack obj); |
There was a problem hiding this comment.
Suggested change
| private static partial bool IsInstanceOf_NoCacheLookup(void *toTypeHnd, bool throwCastException, ObjectHandleOnStack obj); | |
| private static partial bool IsInstanceOf_NoCacheLookup(void *toTypeHnd, [MarshalAs(UnmanagedType.Bool)] bool throwCastException, ObjectHandleOnStack obj); |
am11
reviewed
Nov 21, 2024
| [MethodImpl(MethodImplOptions.InternalCall)] | ||
| private static extern object ChkCastAny_NoCacheLookup(void* toTypeHnd, object obj); | ||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| private static extern object? IsInstanceOfAny_NoCacheLookup(void* toTypeHnd, object obj) |
There was a problem hiding this comment.
Suggested change
| private static extern object? IsInstanceOfAny_NoCacheLookup(void* toTypeHnd, object obj) | |
| private static object? IsInstanceOfAny_NoCacheLookup(void* toTypeHnd, object obj) |
| @@ -230,9 +230,6 @@ extern "C" FCDECL2(VOID, JIT_CheckedWriteBarrier, Object **dst, Object *ref); | |||
| extern "C" FCDECL2(VOID, JIT_WriteBarrier, Object **dst, Object *ref); | |||
| extern "C" FCDECL2(VOID, JIT_WriteBarrierEnsureNonHeapTarget, Object **dst, Object *ref); | |||
|
|
|||
| extern "C" FCDECL2(Object*, ChkCastAny_NoCacheLookup, CORINFO_CLASS_HANDLE type, Object* obj); | |||
| extern "C" FCDECL2(Object*, IsInstanceOfAny_NoCacheLookup, CORINFO_CLASS_HANDLE type, Object* obj); | |||
|
|
|||
| // ARM64 JIT_WriteBarrier uses speciall ABI and thus is not callable directly | |||
There was a problem hiding this comment.
Suggested change
| // ARM64 JIT_WriteBarrier uses speciall ABI and thus is not callable directly | |
| // ARM64 JIT_WriteBarrier uses special ABI and thus is not callable directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.