Fix invalid csharp_space_around_declaration_statements option value

[xtqqczze]

The only valid option values are ignore and false. The default option value is false, so the invalid option value do_not_ignore was implicitly false.

https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/csharp-formatting-options#csharp_space_around_declaration_statements

[xtqqczze]

Build Analysis is green.

[akoeplinger]

the original PR which added the option (dotnet/roslyn#15020) explicitly had ignore/do_not_ignore as options and there's also a test in roslyn that verifies this option parses the same as false. Maybe we should just update the docs?

I'm mainly asking because this value is set in almost all .editorconfig files in the dotnet github org

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

the original PR which added the option (dotnet/roslyn#15020) explicitly had ignore/do_not_ignore as options and there's also a test in roslyn that verifies this option parses the same as false. Maybe we should just update the docs?

It doesn't look that PR actually implemented a do_not_ignore option. In any case, the current implementation only uses ignore and false:

https://github.com/dotnet/roslyn/blob/e628ec67ac5d6cf4ab52650cee1eee45a7738ff6/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpFormattingOptions2.cs#L118-L130

[xtqqczze]

@akoeplinger I've updated the PR description to show this is explicitly flagged as an error in JetBrains Rider.

[akoeplinger]

What Rider does is not relevant here IMO, they've probably just implemented what the docs say.

https://github.com/dotnet/roslyn/blob/e628ec67ac5d6cf4ab52650cee1eee45a7738ff6/src/Workspaces/CSharpTest/Formatting/EditorConfigOptionParserTests.cs#L111-L118 shows the Roslyn test, the implementation just treats any value that is not ignore as false.

Would you mind filing a roslyn issue about this?

I don't particularly care what we set but there are over 60 hits in the dotnet org and I'm not sure it makes sense to just change runtime: https://github.com/search?q=org%3Adotnet+%22do_not_ignore%22+path%3A.editorconfig&type=code

[xtqqczze]

Opened dotnet/roslyn#80996