JIT: Mark non-internal block as imported #122967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JIT has some debug checking that validates that non-internal blocks are always marked `BBF_IMPORTED`. We introduce such a block in the async rewrite (it should not be internal due to debug info), so make sure we uphold that invariant.
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT assertion failure by ensuring that non-internal blocks are always marked with the BBF_IMPORTED flag. When the async transformation creates a new block to rethrow exceptions and removes its BBF_INTERNAL flag (to preserve debug info), it must also set BBF_IMPORTED to maintain the JIT invariant that all non-internal blocks must be marked as imported.
Key Changes
- Added
SetFlags(BBF_IMPORTED)call after removingBBF_INTERNALflag in async.cpp
jakobbotsch
force-pushed
the
fix-122963
branch
from
e9356ed to
b20f749
Compare
Member
Author
|
PTAL @dotnet/jit-contrib |
EgorBo
approved these changes
Jan 9, 2026
Member
Author
|
/ba-g iOS dead letter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JIT has some debug checking that validates that non-internal blocks are always marked
BBF_IMPORTED. We introduce such a block in the async rewrite (it should not be internal due to debug info), so make sure we uphold that invariant.The check happens here:
runtime/src/coreclr/jit/fgdiagnostic.cpp
Lines 114 to 124 in 87b69c5
Fix #122963