Skip to content

Defer DOTNET_DbgEnableMiniDump error message until dump creation #122986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 8 commits into from
Jan 10, 2026
Merged

Defer DOTNET_DbgEnableMiniDump error message until dump creation #122986

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a26bec4
Initial plan
Copilot Jan 7, 2026
7fccb58
Move DOTNET_DbgEnableMiniDump error message to BuildCreateDumpCommand…
Copilot Jan 7, 2026
316bca3
Add comment for clarity in PalCreateDumpInitialize
Copilot Jan 7, 2026
6d701ff
Restore original logic, just move error message to BuildCreateDumpCom…
Copilot Jan 7, 2026
2160148
Fix memory leak when createdump binary doesn't exist
Copilot Jan 7, 2026
ee5bd17
Add g_warnCreateDumpMissing flag to warn in both dump creation paths
Copilot Jan 7, 2026
d2abcab
Extract duplicate error message into constant
Copilot Jan 7, 2026
b00b960
Detect missing createdump at execv time instead of initialization
Copilot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/coreclr/nativeaot/Runtime/unix/PalCreateDump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
const char* g_argvCreateDump[MAX_ARGV_ENTRIES] = { nullptr };
char* g_szCreateDumpPath = nullptr;
char* g_ppidarg = nullptr;
bool g_warnCreateDumpMissing = false;

const char* g_createDumpMissingMessage = "DOTNET_DbgEnableMiniDump is set and the createdump binary does not exist\n";

const size_t MaxUnsigned32BitDecString = STRING_LENGTH("4294967295");
const size_t MaxUnsigned64BitDecString = STRING_LENGTH("18446744073709551615");
Expand Down Expand Up @@ -131,6 +134,10 @@ BuildCreateDumpCommandLine(
{
if (g_szCreateDumpPath == nullptr || g_ppidarg == nullptr)
{
if (g_warnCreateDumpMissing)
{
fprintf(stderr, "%s", g_createDumpMissingMessage);
}
return false;
}

Expand Down Expand Up @@ -465,6 +472,11 @@ PalCreateCrashDumpIfEnabled(int signal, siginfo_t* siginfo, void* context, void*
free(signalAddressArg);
free(exceptionRecordArg);
}
else if (g_warnCreateDumpMissing)
{
// DOTNET_DbgEnableMiniDump was set but createdump binary was not found
fprintf(stderr, "%s", g_createDumpMissingMessage);
}
#endif // !defined(HOST_MACCATALYST) && !defined(HOST_IOS) && !defined(HOST_TVOS)
}

Expand Down Expand Up @@ -624,7 +636,9 @@ PalCreateDumpInitialize()
struct stat fileData;
if (stat(program, &fileData) == -1 || !S_ISREG(fileData.st_mode))
{
fprintf(stderr, "DOTNET_DbgEnableMiniDump is set and the createdump binary does not exist: %s\n", program);
// Createdump binary not found - set flag to warn if someone tries to create a dump
g_warnCreateDumpMissing = true;
free(program);
return true;
}
g_szCreateDumpPath = program;
Expand Down
Loading