Skip to content

skip timeout ping tests if test targets are unreachable #122987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 1 commit into from
Jan 9, 2026
Merged

skip timeout ping tests if test targets are unreachable #122987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,15 +803,20 @@ private async Task Ping_TimedOut_Core(Func<Ping, string, Task<PingReply>> sendPi
reply = await sendPing(sender, TestSettings.UnreachableAddress3);
}

if (reply.Status == IPStatus.DestinationNetworkUnreachable)
{
throw new SkipTestException("Unable to verify timeouts. Skipping test.");
}

Assert.Equal(IPStatus.TimedOut, reply.Status);
}

[Fact]
[ConditionalFact]
[OuterLoop]
public Task Ping_TimedOut_Sync_Success()
=> Ping_TimedOut_Core((sender, address) => Task.Run(() => sender.Send(address)));

[Fact]
[ConditionalFact]
[OuterLoop]
public Task Ping_TimedOut_EAP_Success()
=> Ping_TimedOut_Core(async (sender, address) =>
Expand Down Expand Up @@ -841,7 +846,7 @@ static void PingCompleted(object sender, PingCompletedEventArgs e)
return reply;
});

[Fact]
[ConditionalFact]
[OuterLoop]
public Task Ping_TimedOut_TAP_Success()
=> Ping_TimedOut_Core((sender, address) => sender.SendPingAsync(address));
Expand Down
Loading