Skip to content

Commit

Permalink
Vacuum LLVM code
Browse files Browse the repository at this point in the history
  • Loading branch information
@SingleAccretion
SingleAccretion committed Aug 4, 2024
1 parent 123e6b2 commit 262417c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 898 deletions.
276 changes: 0 additions & 276 deletions src/coreclr/tools/aot/ILCompiler.LLVM/CodeGen/LLVMCodegenCompilation.CodeGen.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@

using System;
using System.Diagnostics;
using System.Numerics;

using ILCompiler.DependencyAnalysis;
using ILCompiler.ObjectWriter;

using Internal.JitInterface;
using Internal.JitInterface.LLVMInterop;
Expand All @@ -17,8 +15,6 @@ namespace ILCompiler
public sealed unsafe partial class LLVMCodegenCompilation
{
internal LLVMContext* LLVMContext { get; } = LLVMContextRef.Create();
internal LLVMType* LLVMInt8Type { get; private set; }
internal LLVMType* LLVMInt16Type { get; private set; }
internal LLVMType* LLVMInt32Type { get; private set; }
internal LLVMType* LLVMInt64Type { get; private set; }
internal LLVMType* LLVMPtrType { get; private set; }
Expand All @@ -28,8 +24,6 @@ public sealed unsafe partial class LLVMCodegenCompilation

private void InitializeCodeGen()
{
LLVMInt8Type = LLVMTypeRef.GetInt(LLVMContext, 8);
LLVMInt16Type = LLVMTypeRef.GetInt(LLVMContext, 16);
LLVMInt32Type = LLVMTypeRef.GetInt(LLVMContext, 32);
LLVMInt64Type = LLVMTypeRef.GetInt(LLVMContext, 64);
LLVMPtrType = LLVMTypeRef.GetPointer(LLVMContext);
Expand All @@ -47,275 +41,5 @@ public override ISymbolNode GetExternalMethodAccessor(MethodDesc method, ReadOnl
}

public override CorInfoLlvmEHModel GetLlvmExceptionHandlingModel() => Options.ExceptionHandlingModel;

internal WasmFunctionType GetWasmFunctionTypeForMethod(MethodSignature signature, bool hasHiddenParam)
{
WasmValueType wasmPointerType = _nodeFactory.Target.PointerSize == 4 ? WasmValueType.I32 : WasmValueType.I64;

WasmValueType GetWasmTypeForTypeDesc(TypeDesc type)
{
switch (type.Category)
{
case TypeFlags.Boolean:
case TypeFlags.SByte:
case TypeFlags.Byte:
case TypeFlags.Int16:
case TypeFlags.UInt16:
case TypeFlags.Char:
case TypeFlags.Int32:
case TypeFlags.UInt32:
return WasmValueType.I32;

case TypeFlags.IntPtr:
case TypeFlags.UIntPtr:
case TypeFlags.Array:
case TypeFlags.SzArray:
case TypeFlags.ByRef:
case TypeFlags.Class:
case TypeFlags.Interface:
case TypeFlags.Pointer:
case TypeFlags.FunctionPointer:
return wasmPointerType;

case TypeFlags.Int64:
case TypeFlags.UInt64:
return WasmValueType.I64;

case TypeFlags.Single:
return WasmValueType.F32;

case TypeFlags.Double:
return WasmValueType.F64;

case TypeFlags.Enum:
return GetWasmTypeForTypeDesc(type.UnderlyingType);

case TypeFlags.Void:
return WasmValueType.Invalid;

default:
throw new UnreachableException(type.Category.ToString());
}
}

WasmValueType GetWasmReturnType(TypeDesc sigReturnType, out bool isPassedByRef)
{
TypeDesc returnType = sigReturnType;
if (IsStruct(sigReturnType))
{
returnType = GetPrimitiveTypeForTrivialWasmStruct(sigReturnType);
}

isPassedByRef = returnType == null;
return isPassedByRef ? WasmValueType.Invalid : GetWasmTypeForTypeDesc(returnType);
}

WasmValueType GetWasmArgTypeForArg(TypeDesc argSigType)
{
bool isPassedByRef = false;
TypeDesc argType = argSigType;
if (IsStruct(argSigType))
{
argType = GetPrimitiveTypeForTrivialWasmStruct(argSigType);
if (argType == null)
{
isPassedByRef = true;
}
}

return isPassedByRef ? wasmPointerType : GetWasmTypeForTypeDesc(argType);
}

WasmValueType wasmReturnType = GetWasmReturnType(signature.ReturnType, out bool isReturnByRef);

int maxWasmSigLength = signature.Length + 4;
Span<WasmValueType> signatureTypes =
maxWasmSigLength > 100 ? new WasmValueType[maxWasmSigLength] : stackalloc WasmValueType[maxWasmSigLength];

int index = 0;
signatureTypes[index++] = wasmPointerType;

if (!signature.IsStatic) // TODO-LLVM-Bug: doesn't handle explicit 'this'.
{
signatureTypes[index++] = wasmPointerType;
}

if (isReturnByRef)
{
signatureTypes[index++] = wasmPointerType;
}

if (hasHiddenParam)
{
signatureTypes[index++] = wasmPointerType;
}

foreach (TypeDesc type in signature)
{
signatureTypes[index++] = GetWasmArgTypeForArg(type);
}

return new WasmFunctionType(wasmReturnType, signatureTypes.Slice(0, index).ToArray());
}

internal LLVMTypeRef GetLLVMSignatureForMethod(MethodSignature signature, bool hasHiddenParam)
{
LLVMTypeRef llvmReturnType = GetLlvmReturnType(signature.ReturnType, out bool isReturnByRef);

int maxLlvmSigLength = signature.Length + 4;
Span<LLVMTypeRef> signatureTypes =
maxLlvmSigLength > 100 ? new LLVMTypeRef[maxLlvmSigLength] : stackalloc LLVMTypeRef[maxLlvmSigLength];

int index = 0;
signatureTypes[index++] = LLVMPtrType;

if (!signature.IsStatic) // TODO-LLVM-Bug: doesn't handle explicit 'this'.
{
signatureTypes[index++] = LLVMPtrType;
}

if (isReturnByRef)
{
signatureTypes[index++] = LLVMPtrType;
}

if (hasHiddenParam)
{
signatureTypes[index++] = LLVMPtrType;
}

foreach (TypeDesc type in signature)
{
signatureTypes[index++] = GetLlvmArgTypeForArg(type);
}

return LLVMTypeRef.CreateFunction(llvmReturnType, signatureTypes.Slice(0, index));
}

public override TypeDesc GetPrimitiveTypeForTrivialWasmStruct(TypeDesc type)
{
int size = type.GetElementSize().AsInt;
if (size <= sizeof(double) && BitOperations.IsPow2(size))
{
while (true)
{
FieldDesc singleInstanceField = null;
foreach (FieldDesc field in type.GetFields())
{
if (!field.IsStatic)
{
if (singleInstanceField != null)
{
return null;
}

singleInstanceField = field;
}
}

if (singleInstanceField == null)
{
return null;
}

TypeDesc singleInstanceFieldType = singleInstanceField.FieldType;
if (!IsStruct(singleInstanceFieldType))
{
if (singleInstanceFieldType.GetElementSize().AsInt != size)
{
return null;
}

return singleInstanceFieldType;
}

type = singleInstanceFieldType;
}
}

return null;
}

public LLVMTypeRef GetLlvmArgTypeForArg(TypeDesc argSigType)
{
bool isPassedByRef = false;
TypeDesc argType = argSigType;
if (IsStruct(argSigType))
{
argType = GetPrimitiveTypeForTrivialWasmStruct(argSigType);
if (argType == null)
{
isPassedByRef = true;
}
}

return isPassedByRef ? LLVMTypeRef.GetPointer(LLVMContext) : GetLLVMTypeForTypeDesc(argType);
}

internal LLVMTypeRef GetLlvmReturnType(TypeDesc sigReturnType, out bool isPassedByRef)
{
TypeDesc returnType = sigReturnType;
if (IsStruct(sigReturnType))
{
returnType = GetPrimitiveTypeForTrivialWasmStruct(sigReturnType);
}

isPassedByRef = returnType == null;
return isPassedByRef ? LLVMVoidType : GetLLVMTypeForTypeDesc(returnType);
}

internal LLVMTypeRef GetLLVMTypeForTypeDesc(TypeDesc type)
{
switch (type.Category)
{
case TypeFlags.Boolean:
case TypeFlags.SByte:
case TypeFlags.Byte:
return LLVMInt8Type;

case TypeFlags.Int16:
case TypeFlags.UInt16:
case TypeFlags.Char:
return LLVMInt16Type;

case TypeFlags.Int32:
case TypeFlags.UInt32:
return LLVMInt32Type;

case TypeFlags.IntPtr:
case TypeFlags.UIntPtr:
return _nodeFactory.Target.PointerSize == 4 ? LLVMInt32Type : LLVMInt64Type;

case TypeFlags.Array:
case TypeFlags.SzArray:
case TypeFlags.ByRef:
case TypeFlags.Class:
case TypeFlags.Interface:
case TypeFlags.Pointer:
case TypeFlags.FunctionPointer:
return LLVMPtrType;

case TypeFlags.Int64:
case TypeFlags.UInt64:
return LLVMInt64Type;

case TypeFlags.Single:
return LLVMFloatType;

case TypeFlags.Double:
return LLVMDoubleType;

case TypeFlags.Enum:
return GetLLVMTypeForTypeDesc(type.UnderlyingType);

case TypeFlags.Void:
return LLVMVoidType;

default:
throw new UnreachableException(type.Category.ToString());
}
}

private static bool IsStruct(TypeDesc type) => type.Category is TypeFlags.ValueType or TypeFlags.Nullable;
}
}
Loading

0 comments on commit 262417c

Please sign in to comment.