[NativeAOT-LLVM] Rewrite exception handling to support nested dispatch #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size statistics: All table formats: 0x00113384 + 0.08% + 924 bytes Excluding "small": 0x001135b4 + 0.13% + 1484 bytes Excluding "small" and "clause type": 0x001138d8 + 0.20% + 2288 bytes About ~2.5x win for the more complex format as compared to the naive option.
SingleAccretion
force-pushed
the
EH-Unwind
branch
from
c176fb7
to
2d1fb5c
Compare
Using funclets for now. Also deletes the dynamic stack support (no longer needed).
And delete the unused CORINFO_HELP_LLVM_EH_CATCH_POP_UNWOUND_VIRTUAL_FRAMES.
SingleAccretion
force-pushed
the
EH-Unwind
branch
from
2d1fb5c
to
98473f7
Compare
|
@dotnet/nativeaot-llvm |
jkotas
added
the
area-NativeAOT-LLVM
yowl
approved these changes
Aug 24, 2023
Co-authored-by: yowl <[email protected]>
|
Thank you for the hard work and dedication! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added
nativeaot-wasm-exception-handling.mdfor an explanation of how the new EH scheme works. Feedback on what to improve in it is most welcome (e. g. some parts are not detailed enough, or unclear, or some terms are not explained, etc)!Contributes to #2169.