Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WCF sample Instancing/Lifetime to conditionally support .NET framework / Core #6281

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update WCF sample Instancing/Lifetime to conditionally support .NET framework / Core #6281

wants to merge 1 commit into from

Conversation

afifi-ins
Copy link
Contributor

No description provided.

@mconnew
Copy link
Member

mconnew commented Oct 31, 2023

Everything so far looks good. Need to update coding style to:

  • Specify accessibility of members
  • Use auto properties
  • One line methods use expression method bodies
  • Update private field naming to current convention of starting with _
  • Make constant strings const

@afifi-ins afifi-ins force-pushed the WcfSamplesUpgrade/InstanceLifetime branch from 259b43e to 9a181d8 Compare November 3, 2023 07:59
mconnew
mconnew approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@mconnew mconnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconnew mconnew mconnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afifi-ins @mconnew