Remove RunSettingsFilePath support from dotnet test for MTP #47706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-dotnet test
untriaged
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for RunSettingsFilePath from the dotnet test command, as part of cleaning up obsolete functionality.
- Removed logging and serialization/deserialization of RunSettingsFilePath in various modules.
- Updated the TestModule and ModuleMessage records to no longer include the RunSettingsFilePath property.
- Removed environment variable configuration and project property extraction related to RunSettingsFilePath.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs | Removed RunSettingsFilePath logging from project properties output. |
| src/Cli/dotnet/commands/dotnet-test/IPC/Serializers/ModuleMessageSerializer.cs | Removed serialization and deserialization of RunSettingsFilePath. |
| src/Cli/dotnet/commands/dotnet-test/Models.cs | Removed RunSettingsFilePath from the TestModule record. |
| src/Cli/dotnet/commands/dotnet-test/IPC/Models/ModuleMessage.cs | Removed RunSettingsFilePath from the ModuleMessage record. |
| src/Cli/dotnet/commands/dotnet-test/CliConstants.cs | Removed the RunSettingsFilePath constant from ProjectProperties. |
| src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs | Updated TestModule instantiation to omit RunSettingsFilePath. |
| src/Cli/dotnet/commands/dotnet-test/TestModulesFilterHandler.cs | Updated TestApplication creation to match the new TestModule signature. |
| src/Cli/dotnet/commands/dotnet-test/TestApplication.cs | Removed RunSettingsFilePath environment variable setup from the test runner. |
Youssef1313
force-pushed
the
dev/ygerges/runsettings
branch
from
4f83a4f to
f2cf1d5
Compare
Evangelink
approved these changes
Mar 18, 2025
mariam-abdulla
approved these changes
Mar 19, 2025
I didn't double check, but I think it will work only when using Microsoft.Testing.Platform.MSBuild, as the logic to copy the file is done there. I'm not sure whether or not this is reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47636
Related to #45927
If we want to support that, it should be part of VSTestBridge by hooking into ComputeRunArguments and passing
RunSettingsFilePathvia--settingsinstead of using environment variable.