Run all steps in a container #44969
Run all steps in a container #44969
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Source-build isn't running all steps in containers: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585278&view=results The legs don't run the "initialize containers" step, so I'm working to determine why. This doesn't happen in PR checks. |
| ./build.sh $buildArgs | ||
| fi | ||
| for envVar in $customEnvVars; do | ||
| customEnvVarsWithBashSyntax="$customEnvVarsWithBashSyntax export $envVar;" |
There was a problem hiding this comment.
One convenient thing we lost here is the easy way of simulating offline. We will have to now disable the network "manually"
|
/azp run dotnet-source-build-lite |
|
No pipelines are associated with this pull request. |
This is because the internal pipelines use 1ES PTs. I'm adjusting the templates so that the containers work in with these yamls. |
| - ${{ if ne(parameters.runOnline, 'True') }}: | ||
| - script: | | ||
| set -ex | ||
| sudo ip link set eth0 down |
There was a problem hiding this comment.
iproute2 is not installed, so I can't run the above command. I can either adjust the Dockerfiles or try to install it here in the pipeline. Installing in the pipeline would likely involve trying to work around different distros' package managers.
There was a problem hiding this comment.
@mthalman or @lbussell - Do you have thoughts on the above?
Also related, I tested the above command out by installing iproute2 in a local docker container using the ubuntu 24.04 buildtools prereqs image. I found that I needed privileged access to run ip link set eth0 down. Given that the container is not manually configured, I worry about the fact that I may not be able to run the command in the pipelines even after installing iproute2. I don't think that the use of sudo fixes this issue.
Fixes dotnet/source-build#4547