Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit Compatiblity tools improvements #45685

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Nit Compatiblity tools improvements #45685

merged 1 commit into from
Jan 7, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jan 2, 2025 •
edited
Loading

Use collection initializers, fix spelling checks via suppression and a few other nits

@ViktorHofer ViktorHofer requested a review from a team as a code owner January 2, 2025 17:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Jan 2, 2025
@build-analysis build-analysis bot mentioned this pull request Jan 2, 2025
Open
3 tasks
@ViktorHofer ViktorHofer enabled auto-merge (squash) January 7, 2025 22:02
carlossanlop
carlossanlop approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CompositeSymbolFilter file is the only one that will collide with my ApiDiff PR.

@ViktorHofer ViktorHofer merged commit 39da6dd into main Jan 7, 2025
34 of 37 checks passed
@ViktorHofer ViktorHofer deleted the SmallAPICompatImprovements branch January 7, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@ericstj ericstj Awaiting requested review from ericstj

Assignees
No one assigned
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @carlossanlop