[release/8.0.4xx] Manual Backport of #40611 to 8.0.4xx - Allow users to set a specific ContainerImageFormat to force OCI support #46140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
surayya-MS
approved these changes
Jan 20, 2025
baronfel
changed the title
baronfel
added
Servicing-consider
Area-Containers
surayya-MS
reviewed
Jan 21, 2025
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
baronfel
force-pushed
the
backport-40611-to-8.0.4xx
branch
from
20890c9 to
419231f
Compare
|
Waiting to merge until the March release merge window. |
|
@baronfel there are merge conflicts to be resolved. |
|
Resolved! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46011 to release/8.0.4xx
Description
This change allows users to explicitly request a specific format of Container (Docker or OCI) instead of relying on our existing "same as the base image" strategy. This need to explicitly override the base image's format comes from an internal partner request, where that partner needs OCI outputs only, but the .NET Container images are in Docker format for now and the forseeable future.
Customer Impact
With this change, a user that opts into the new behavior will have explicit control over their generated container's format. A customer that doesn't interact with the feature keeps the same behavior as prior versions.
Regression
No
Risk
Low - we have the needed conversion/schema functionality in the tooling already, this just surfaces a user-facing knob. We also have automated tests added to verify the feature.