Enable building sdk tests in the VMR #47103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying issue is now closed.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
mmitche
approved these changes
Feb 25, 2025
NikolaMilosavljevic
approved these changes
Feb 25, 2025
|
This is causing an issue with building tests on Linux - #47106 (comment) Are we still missing some changes for addressing the underlying issue? @ViktorHofer @mmitche |
|
It seems that TestHost package is still only building on Windows: https://github.com/microsoft/vstest/pull/15001/files I think we should disable SDK tests on non-Windows - essentially revert this PR. |
|
OK, makes sense. I was under the assumption that we changed building the package always except in source-build. Sorry for causing additional work here. Feel free to include this revert in your other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue is now closed.