Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version badge moniker for linux-musl-* #47156

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Fix version badge moniker for linux-musl-* #47156

merged 1 commit into from
Feb 27, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 27, 2025

Fixes dotnet/source-build#4919

The badge for linux-musl-arm and linux-musl-arm64 isn't produced correctly. See https://github.com/dotnet/sdk/blob/main/documentation/package-table.md and https://github.com/dotnet/dotnet/blob/main/docs/builds-table.md

The previous condition only worked for linux-musl-x64 but not for linux-musl-arm64 and linux-musl-arm that we are also building.

Also remove a dead property

The previous condition only worked for linux-musl-x64 but not for linux-musl-arm64 and linux-musl-arm that we are also building.

Also remove a dead property
@Copilot Copilot bot review requested due to automatic review settings February 27, 2025 11:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Workloads untriaged Request triage from a team member labels Feb 27, 2025
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 27, 2025 11:54
@ViktorHofer ViktorHofer merged commit 16f27df into main Feb 27, 2025
42 checks passed
@ViktorHofer ViktorHofer deleted the linuxmuslbadge branch February 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the build table in dotnet/dotnet with all supported platforms
2 participants