Skip to content

Conversation

nobowned
Copy link

@nobowned nobowned commented May 8, 2025

@nobowned nobowned requested a review from a team as a code owner May 8, 2025 23:17
@nobowned
Copy link
Author

nobowned commented May 8, 2025

@dotnet-policy-service agree company="Verisk"

Copy link
Contributor

@edvilme edvilme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking this. It looks good overall, but my main concern would mostly be adding the slnx files to the tests, and some nit comments

@nobowned
Copy link
Author

The tests should pass once dotnet/templating#9011 is merged

@dominikhuembeli
Copy link

We're encountering the same issue where projects created from custom .NET templates aren't being added to the .slnx file. This PR looks like it would solve the problem—do you have an estimated timeline for when it might be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants