Skip to content

Handle assemblies gracefully #52308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariam-abdulla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle assemblies gracefully #52308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,11 @@ internal void TestCompleted(
string? standardOutput,
string? errorOutput)
{
TestProgressState asm = _assemblies[executionId];
if (!_assemblies.TryGetValue(executionId, out TestProgressState? asm))
{
// This should not happen in normal scenarios, but handle gracefully
return;
}
var attempt = asm.TryCount;

if (_options.ShowActiveTests)
Expand Down Expand Up @@ -731,7 +735,21 @@ internal void AssemblyRunCompleted(string executionId,
// In single process run, like with testing platform .exe we report these via messages, and run exit.
int exitCode, string? outputData, string? errorData)
{
TestProgressState assemblyRun = _assemblies[executionId];
// The executionId may not exist in the dictionary if the host type is not "TestHost"
// (e.g., TestHostController), since AssemblyRunStarted is only called for TestHost.
if (!_assemblies.TryGetValue(executionId, out TestProgressState? assemblyRun))
{
// No assembly run state to update, but still report on non-zero exit codes
if (exitCode != 0)
{
_terminalWithProgress.WriteToTerminal(terminal =>
{
AppendExecutableSummary(terminal, exitCode, outputData, errorData);
});
}
return;
}

assemblyRun.Success = exitCode == 0 && assemblyRun.FailedTests == 0;
assemblyRun.Stopwatch.Stop();

Expand Down Expand Up @@ -903,7 +921,11 @@ internal void TestDiscovered(
return;
}

TestProgressState asm = _assemblies[executionId];
if (!_assemblies.TryGetValue(executionId, out TestProgressState? asm))
{
// This should not happen in normal scenarios, but handle gracefully
return;
}

// TODO: add mode for discovered tests to the progress bar - jajares
asm.DiscoverTest(displayName, uid);
Expand Down Expand Up @@ -989,7 +1011,11 @@ public void TestInProgress(
string displayName,
string executionId)
{
TestProgressState asm = _assemblies[executionId];
if (!_assemblies.TryGetValue(executionId, out TestProgressState? asm))
{
// This should not happen in normal scenarios, but handle gracefully
return;
}

if (_options.ShowActiveTests)
{
Expand Down
Loading