Skip to content

[WIP] Support boolean values for --self-contained flag #52333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
+8 −7
Closed

[WIP] Support boolean values for --self-contained flag #52333

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47f81fb
Initial plan
Copilot Jan 6, 2026
03292b0
Support boolean values for --self-contained flag
Copilot Jan 6, 2026
ba0135a
Fix the logic to only set self contained when specified
marcpopMSFT Jan 9, 2026
1a39d27
Merge branch 'release/10.0.2xx' into copilot/support-self-contained-b…
marcpopMSFT Jan 9, 2026
4c64979
Change SelfContainedOption type to nullable boolean
marcpopMSFT Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/Build/BuildCommandDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ internal static class BuildCommandDefinition

public static readonly Option<bool> NoRestoreOption = CommonOptions.NoRestoreOption;

public static readonly Option<bool> SelfContainedOption = CommonOptions.SelfContainedOption;
public static readonly Option<bool?> SelfContainedOption = CommonOptions.SelfContainedOption;

public static readonly Option<bool> NoSelfContainedOption = CommonOptions.NoSelfContainedOption;

Expand Down
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/Publish/PublishCommandDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal static class PublishCommandDefinition

public static readonly Option<bool> NoRestoreOption = CommonOptions.NoRestoreOption;

public static readonly Option<bool> SelfContainedOption = CommonOptions.SelfContainedOption;
public static readonly Option<bool?> SelfContainedOption = CommonOptions.SelfContainedOption;

public static readonly Option<bool> NoSelfContainedOption = CommonOptions.NoSelfContainedOption;

Expand Down
11 changes: 6 additions & 5 deletions src/Cli/dotnet/CommonOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,13 @@ public static Option<bool> CreateInteractiveOption(bool acceptArgument = false,
Arity = ArgumentArity.Zero,
};

public static Option<bool> SelfContainedOption =
new Option<bool>("--self-contained", "--sc")
public static Option<bool?> SelfContainedOption =
new Option<bool?>("--self-contained", "--sc")
{
Description = CliStrings.SelfContainedOptionDescription
Description = CliStrings.SelfContainedOptionDescription,
Arity = ArgumentArity.ZeroOrOne
}
.ForwardIfEnabled([$"--property:SelfContained=true", "--property:_CommandLineDefinedSelfContained=true"]);
.ForwardAsMany(o => o.HasValue ? [$"--property:SelfContained={o.Value}", "--property:_CommandLineDefinedSelfContained=true"] : []);

public static Option<bool> NoSelfContainedOption =
new Option<bool>("--no-self-contained")
Expand All @@ -353,7 +354,7 @@ public static Option<bool> CreateInteractiveOption(bool acceptArgument = false,
};

public static readonly Option<IReadOnlyDictionary<string, string>> EnvOption = CreateEnvOption(CliStrings.CmdEnvironmentVariableDescription);

public static readonly Option<IReadOnlyDictionary<string, string>> TestEnvOption = CreateEnvOption(CliStrings.CmdTestEnvironmentVariableDescription);

private static IReadOnlyDictionary<string, string> ParseEnvironmentVariables(ArgumentResult argumentResult)
Expand Down